Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): should not take unmount children fast path if children contain cached nodes #8809

Closed
wants to merge 2 commits into from

Conversation

edison1105
Copy link
Member

close #5154

@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.9 kB (+53 B) 32.7 kB (+12 B) 29.5 kB (+14 B)
vue.global.prod.js 132 kB (+96 B) 49.4 kB (+26 B) 44.4 kB (+19 B)

Usages

Name Size Gzip Brotli
createApp 47.9 kB (+52 B) 18.9 kB (+23 B) 17.2 kB (+13 B)
createSSRApp 50.7 kB (+52 B) 20 kB (+24 B) 18.2 kB (+21 B)
defineCustomElement 50.3 kB (+52 B) 19.7 kB (+17 B) 17.9 kB (+18 B)
overall 61.3 kB (+52 B) 23.7 kB (+21 B) 21.6 kB (+8 B)

@yyx990803 yyx990803 closed this in d343a0d Jul 13, 2024
@yyx990803
Copy link
Member

The direction is right, but checking only the direct children of the current vnode does not account for deeply nested v-once cached nodes.

In d343a0d I use setBlockTracking to mark the entire block to avoid this problem.

jacobfogolyan pushed a commit to jacobfogolyan/vuejs-core that referenced this pull request Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

v-once and "unmount callbacks", possible memory leak?
2 participants