-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(reactivity): don't convert Set into array #8718
Conversation
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
// spread into array for stabilization | ||
const effects = isArray(dep) ? dep : [...dep] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the reason for copying the dep
into an array is to ensure that the subsequent iterations are stable. The calls to triggerEffect()
inside those loops could modify dep
while we're trying to iterate over it.
The PR description and linked issue don't seem to mention this, so I'm wondering whether there's been a misunderstanding about the purpose of the array?
close #8714