Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(reactivity): don't convert Set into array #8718

Closed
wants to merge 5 commits into from
Closed

refactor(reactivity): don't convert Set into array #8718

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e54464
chore: there is no need to convert the Set into an array
Alfred-Skyblue Jul 4, 2023
26c699d
Merge branch 'main' into chore-dep
Alfred-Skyblue Jul 10, 2023
4f52342
Merge branch 'main' into chore-dep
Alfred-Skyblue Jul 18, 2023
14ad7fc
Merge branch 'main' into chore-dep
Alfred-Skyblue Aug 14, 2023
233d97d
Merge branch 'main' into chore-dep
sxzz Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/reactivity/src/effect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,17 +391,15 @@ export function trigger(
}

export function triggerEffects(
dep: Dep | ReactiveEffect[],
dep: Dep,
debuggerEventExtraInfo?: DebuggerEventExtraInfo
) {
// spread into array for stabilization
const effects = isArray(dep) ? dep : [...dep]
Comment on lines -397 to -398
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the reason for copying the dep into an array is to ensure that the subsequent iterations are stable. The calls to triggerEffect() inside those loops could modify dep while we're trying to iterate over it.

The PR description and linked issue don't seem to mention this, so I'm wondering whether there's been a misunderstanding about the purpose of the array?

for (const effect of effects) {
for (const effect of dep) {
if (effect.computed) {
triggerEffect(effect, debuggerEventExtraInfo)
}
}
for (const effect of effects) {
for (const effect of dep) {
if (!effect.computed) {
triggerEffect(effect, debuggerEventExtraInfo)
}
Expand Down
Loading