Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give the vue dev tool the ablity to select the correspond component w… #469

Closed
wants to merge 1 commit into from

Conversation

zzuligy
Copy link

@zzuligy zzuligy commented Dec 12, 2017

provide vue dev tool the ablity to select the the correspond component when select a page element by inspector.
when the page has lots of component,this function can let the develop find the correspond compoent more fastly.
2017-12-12 18 16 41

}
})
//sort ancestor
instanceContainer.sort(function (m, n) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the sort for here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because when find the component containg the dom,there may be many.sort the component,and get the nearest component which is the selected one.

Copy link
Author

@zzuligy zzuligy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Akryum's implement is more elegant .please make it publish fast,which can make many people benefit.

}
})
//sort ancestor
instanceContainer.sort(function (m, n) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because when find the component containg the dom,there may be many.sort the component,and get the nearest component which is the selected one.

@posva
Copy link
Member

posva commented Dec 26, 2017

do you mean #479 ?

@yyx990803 yyx990803 mentioned this pull request Dec 26, 2017
16 tasks
@zzuligy
Copy link
Author

zzuligy commented Dec 27, 2017

yes.we do the same thing.but his code is more elegant.for example the contextMenu,the vue, the exapnd of the selected component

@Akryum
Copy link
Member

Akryum commented Jan 3, 2018

I guess we will go with #476 and #479. Thanks @zzuligy for your work! 👍

@Akryum Akryum closed this Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants