Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click Inspect component + this.$inspect() #479

Merged
merged 17 commits into from
Jan 12, 2018

Conversation

Akryum
Copy link
Member

@Akryum Akryum commented Dec 24, 2017

Fix #242

  • Right-click inspect
  • this.$inspect()

vue-devtools-right-click-inspect

@posva
Copy link
Member

posva commented Dec 24, 2017

It works, good job!
Is it possible to disable or remove the option if the right click isn't on a vue component (outside of Vue scope). I was testing on Vue docs and right-clicking outside of examples gives no feedback

})

function onPanelLoad () {
pendingAction && pendingAction()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when does the pendingAction gets executed? I couldn't test this one
Depending on when it is triggered, it may be better to set pendingAction back to null

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@posva
Copy link
Member

posva commented Dec 24, 2017

Some other thoughts:

  • if possible, it would be nice to open devtools and focus vue-devtools as well
  • did you get any chance of testing this on Firefox? I couldn't load a plugin from a file, I think I need to package it first

@Akryum
Copy link
Member Author

Akryum commented Dec 24, 2017

Is it possible to disable or remove the option if the right click isn't on a vue component (outside of Vue scope).

Maybe. I'll investigate this. At least we could display something like a toast with a message.

if possible, it would be nice to open devtools and focus vue-devtools as well

Unfortunately, this is impossible. Devtools must be open manually.

did you get any chance of testing this on Firefox?

No, will try.

@Akryum
Copy link
Member Author

Akryum commented Dec 24, 2017

vue-devtools-toast

@Akryum
Copy link
Member Author

Akryum commented Dec 24, 2017

vue-devtools-toast2

@Akryum
Copy link
Member Author

Akryum commented Dec 24, 2017

vue-devtools-toast3

@Akryum
Copy link
Member Author

Akryum commented Dec 24, 2017

capture d ecran du 2017-12-24 17 28 54

@zzuligy
Copy link

zzuligy commented Dec 26, 2017

nice work.put the inspect in menu could make the workflow fast which is better than react devtool.
but when i run,there is a error.
image

@Akryum
Copy link
Member Author

Akryum commented Dec 26, 2017

@zzuligy Fixed! 🔧

@yyx990803 yyx990803 mentioned this pull request Dec 26, 2017
16 tasks
@Akryum
Copy link
Member Author

Akryum commented Dec 26, 2017

@posva I added this.$inspect() in this PR as well, since it was mostly the same need.

@Akryum Akryum changed the title Right click Inspect component Right click Inspect component + this.$inspect() Dec 26, 2017
@Akryum
Copy link
Member Author

Akryum commented Dec 27, 2017

Tested in Firefox 👌

@scottbedard
Copy link

Thank you for this!

@pschaub
Copy link

pschaub commented Jan 4, 2018

Can we merge this now? This feature is really awesome! 👍

@yyx990803 yyx990803 merged commit 2f2f4e3 into vuejs:master Jan 12, 2018
@pepoospina
Copy link

I am having erratic behavior. Most of the times the option is not available in the context menu after I right click on it. But in some occasions it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants