🎄 2017 Winter Holidays update #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
added 7 commits
January 4, 2018 19:28
…rome-devtools-context' into 2017-winter-holidays
Akryum
commented
Jan 4, 2018
| @@ -49,7 +49,7 @@ export default { | |||
| data () { | |||
| return { | |||
| filter: '', | |||
| isChrome: typeof chrome !== 'undefined' && chrome.devtools | |||
| isChrome: typeof chrome !== 'undefined' && !!chrome.devtools | |||
docs/open-in-editor.md
Outdated
| } | ||
| } | ||
| ``` | ||
|
|
||
| 3. You can change `'code'` with the editor you are using, see the [supported editors list](https://github.com/lahmatiy/open-in-editor#editor). | ||
| 3. The editor to launch is guessed. You can also specify the editor app with the `editor` option. See the [supported editors list](https://github.com/lahmatiy/open-in-editor#editor). |
There was a problem hiding this comment.
Supported editors was added in the launch-editor package.
https://github.com/yyx990803/launch-editor#supported-editors
|
Absolutely amazing job @Akryum, every feature works flawlessly!!! |
|
Chrome is notifying me that this release requires new permissions, there should be a note somewhere explaining why. |
|
Seems like the new permission has been removed in the latest commit. Looking forward to a new version soon 👍 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains merges, fixes and minor changes for the following PRs:
Fix #338