Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable fields #484

Merged
merged 22 commits into from
Jan 12, 2018
Merged

Editable fields #484

merged 22 commits into from
Jan 12, 2018

Conversation

Akryum
Copy link
Member

@Akryum Akryum commented Dec 27, 2017

Fix #74

  • Some fields of component local state are editable
  • Warning if JSON is invalid
  • Edit values inside arrays and objects
  • Add items in arrays and objects
  • Remove items in arrays and objects
  • Edit the full array or object
  • Autocomplete special values (maybe they can be formatted with a contenteditable instead of an input)
  • Quick Edit for booleans: toggle true/false
  • Quick Edit for numbers: +1/-1 (with keyboard modifiers)

More types (RegExp + Dates) can be enabled after #474 is merged

vue-devtools-edit

vue-devtools-edit2

vue-devtools-edit3

@yyx990803 yyx990803 mentioned this pull request Dec 27, 2017
16 tasks
@Akryum
Copy link
Member Author

Akryum commented Dec 27, 2017

I added some autocompletion for special JSON values:

vue-devtools-edit4

@Akryum
Copy link
Member Author

Akryum commented Dec 27, 2017

vue-devtools-edit6

@Akryum
Copy link
Member Author

Akryum commented Dec 27, 2017

capture d ecran du 2017-12-27 19 59 00

@Akryum
Copy link
Member Author

Akryum commented Dec 27, 2017

capture d ecran du 2017-12-27 20 18 06

@Akryum
Copy link
Member Author

Akryum commented Dec 27, 2017

capture d ecran du 2017-12-27 20 37 09

@Akryum
Copy link
Member Author

Akryum commented Dec 27, 2017

capture d ecran du 2017-12-27 21 28 41

@crswll
Copy link
Contributor

crswll commented Dec 28, 2017

Dude. Awesome.

@Akryum
Copy link
Member Author

Akryum commented Dec 28, 2017

capture d ecran du 2017-12-28 03 04 44

capture d ecran du 2017-12-28 03 05 31

@Akryum Akryum requested a review from posva December 28, 2017 02:12
@Akryum Akryum requested a review from yyx990803 December 28, 2017 02:12
@DannyFeliz
Copy link

Dude, this is amazing

@michalsnik michalsnik added this to the 🎄Holiday Update milestone Jan 3, 2018
@posva
Copy link
Member

posva commented Jan 7, 2018

This is clearly the best one 😄

For the increment/decrement controls on numbers, there are the same problems as with collapse/expand. Control-click won't work in mack, so it should be cmd + click

@posva
Copy link
Member

posva commented Jan 7, 2018

By testing a bit I found this behaviour:

screenflow

Adding multiple elements to an array adds first undefined, then the special value used for devtools

@Akryum
Copy link
Member Author

Akryum commented Jan 7, 2018

This is all fixed! Also, I changed 'Alt' to 'Option' key on Mac for the relevant tooltips.

@yyx990803 yyx990803 merged commit a7e182a into vuejs:master Jan 12, 2018
@gonzaloserrano
Copy link

Hi there, I'm using 4.1.4 and I'm not beeing able to edit anything inside the chrome vuex panel. I'm using Vue 2.5.13.

screenshot 2018-03-16 12 28 11

Any hints?

@Akryum
Copy link
Member Author

Akryum commented Mar 16, 2018

@gonzaloserrano Vuex state is not editable at this time. This is planned though (and you can open a feature request in another issue 😉).

@gonzaloserrano
Copy link

OK, I thought this issue was exactly about implementing this. Thanks for your quick response!

@lloydjatkinson
Copy link

Will this be added to Vuex?

@Akryum
Copy link
Member Author

Akryum commented Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants