Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapsable and redesigned state inspector #477

Merged
merged 3 commits into from
Jan 12, 2018
Merged

Collapsable and redesigned state inspector #477

merged 3 commits into from
Jan 12, 2018

Conversation

Akryum
Copy link
Member

@Akryum Akryum commented Dec 23, 2017 •
edited
Loading

  • Sections in state inspector are now collapsable
  • Shift + Click and Ctrl + Click to expand/collapse all sections
  • They are also redesigned
  • Some style refactoring
  • Vuex history items have now the same height as Events history items

vue-devtool-collpase-data-sections

@Akryum Akryum changed the title Collapsable and redesigned state inscpector Collapsable and redesigned state inspector Dec 23, 2017
@Akryum Akryum mentioned this pull request Dec 23, 2017
Closed
@posva
Copy link
Member

posva commented Dec 23, 2017

Looks nice, I prefer it to #392

@Akryum Akryum mentioned this pull request Dec 23, 2017
Closed
@yyx990803 yyx990803 mentioned this pull request Dec 26, 2017
Closed
16 tasks
@posva
Copy link
Member

posva commented Dec 31, 2017

Testing on mac, it doesn't seem to expand or collapse all. Also, I would update the popover to display cmd or the unicode symbol

@Akryum
Copy link
Member Author

Akryum commented Dec 31, 2017

Fixed by Akryum@5b7745d

@Akryum Akryum mentioned this pull request Dec 31, 2017
Merged
@michalsnik michalsnik added this to the 🎄Holiday Update milestone Jan 3, 2018
@posva
Copy link
Member

posva commented Jan 7, 2018

Works nicely now!

Some extra thoughts for the future:

  • remove the pointer cursor on properties (something like .key:not(.abstract), .colon, .value {cursor: initial;}
  • make some of the tree parts non selectable (this may have some edge cases

@yyx990803 yyx990803 merged commit f1802a7 into vuejs:master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
🎄Holiday Update
Development

Successfully merging this pull request may close these issues.
4 participants
@Akryum @posva @yyx990803 @michalsnik