This repository has been archived by the owner on Aug 8, 2022. It is now read-only.
review reactiveity.md and reactivity-fundamentals.md and change some content #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heart-er
commented
Sep 8, 2020
•
heart-er
commented
- 对 reactivity.md 进行了相关修改
- 对 reactivity-fundamentals.md 进行了相关修改
veaba
reviewed
Sep 8, 2020
src/guide/reactivity.md
Outdated
|
|
||
| ## 什么是响应式 | ||
|
|
||
| 这些天在编程中经常出现，但是人们说的意思是什么？响应式是一种编程范例，允许我们以声明的方式适应变化。人们经常展示的典型示例 (因为它是一个很棒的示例) 是 excel 电子表格。 | ||
| 这个术语在程序设计中经常被提及，但这是什么意思呢？响应式是一种允许我们已声明式的方式去适应变化的一种编程范例。人们通常展示的典型例子，是一份excel电子表格（一个非常好的例子）。 |
There was a problem hiding this comment.
@heart-er ，英文和中文之间理应由空格区分开，建议参考：https://github.com/vuejs/docs-next-zh-cn/wiki/%E5%8D%8F%E4%BD%9C%E6%8C%87%E5%8D%97#6-%E5%85%B6%E5%AE%83 校验一下。:tada:
There was a problem hiding this comment.
嗯嗯 好的 已经更改~ 另外好像我把 src/guide/reactivity-fundamentals.md 校对 的内容 也提交到一个 pr了 是否需要重新拉分支分开呢？
There was a problem hiding this comment.
嗯嗯 好的 已经更改~ 另外好像我把 src/guide/reactivity-fundamentals.md 校对 的内容 也提交到一个 pr了 是否需要重新拉分支分开呢？
非常感谢你的PR，下面有几个小问题，可以试着修正下哈：
- 如果内容文件比较多的话，可以试着新开分支，这样会比较专注一个 pr 做专门的 review 😂。
- 另外，我看你每次commit 的message 都一样，这个能每次 commit 时候都标注下嘛，都一样的话，就比较难看到更改了什么了。
- 参考 commit message 的一些约定
- 可以在描述里阐明这个 PR 都做了些什么，类似 docs: polishe a11y-basics #11 ，比较方便理解阅读。
heart-er
changed the title
Jinjiang
reviewed
Sep 13, 2020
Jinjiang
approved these changes
Sep 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.