Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy to clipboard button style #819

Closed
3 tasks done
RainKolwa opened this issue Jun 20, 2022 · 3 comments · Fixed by #1998
Closed
3 tasks done

copy to clipboard button style #819

RainKolwa opened this issue Jun 20, 2022 · 3 comments · Fixed by #1998
Assignees
Labels
theme Related to the theme
Milestone

Comments

@RainKolwa
Copy link
Contributor

Describe the bug

If the code sample reached a bit long, the copy button and copied tip are not clear enough to recognize.

Reproduction

image

Expected behavior

copy button to be clear.

System Info

-

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@RainKolwa RainKolwa added the bug: pending triage Maybe a bug, waiting for confirmation label Jun 20, 2022
@brc-dd brc-dd added theme Related to the theme and removed bug: pending triage Maybe a bug, waiting for confirmation labels Jun 20, 2022
@kiaking kiaking added the bug label Jun 21, 2022
@kiaking kiaking added this to the v1.0.0 milestone Jun 21, 2022
@Zelig880
Copy link

The buttons currently use opacity to achieve the light hover effect, but it would probably benefit to have a solid colour (as the hover effect is a solid colour anyway(.

For future reference this is the class (and CSS variable) that handle the hover effect of the copy button:
Screenshot 2022-06-26 at 21 48 40

We could change and actually define some borders instead than background-colour. This is an example of using (--vp-c-text-3) - (yeah I know it is for text, I was just trying to use existing colors):
Screenshot 2022-06-26 at 21 58 00

Note: If we do use background color, we should also make sure we add a black border when the button is not hovered, to avoid flicks and movement when the button is hovered!

@kiaking
Copy link
Member

kiaking commented Jun 27, 2022

Yeah I've used opacity to make style customization a bit easier but seems like we have to use solid background 😅

I'm fine with that. This issue is on the 1.0.0 milestone so eventually I'll fix this 👍

@g4rry420
Copy link
Contributor

g4rry420 commented Sep 21, 2022

Hi, Can I work on this issue ?
I am thinking of using this color rgba(38,38,38,255) which will be closest to that opacity of black color.

@kiaking kiaking self-assigned this Jan 20, 2023
kiaking added a commit that referenced this issue Feb 28, 2023
) (#1998)

fix #819
fix #1892

Co-authored-by: Divyansh Singh <40380293+brc-dd@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme Related to the theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants