-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme): "copy code" button not readable on hover state (#819) #1998
Conversation
Rest LGTM. Closes #1892 too IG? |
Thanks! Ahhh #1892. I'll double check this to see if it works with this change 🤔 |
OK I've tweaked a bit and checked. Now the current one is not that bad but not perfect I would say. If we increase the top padding to 24px and then move the lang label up for another 2px looks perfect, when there is line hightlight on the first line. But then the rest of code block with no line highlight looks a bit worse (in my opinion) 🤔 Top/Bottom padding would be too big, and lang label is too near the edge. So, I say, having line highlight on the very first line should be rare, therefore the current stye is best for overall design 😳 |
fix #819
fix #1892
This PR does 2 things.