SFC parseComponent pads complete content with spaces #5059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when `{ pad: true }` is provided. That is, all content is converted to
spaces. Previously, each line was truncated to "//". The new padding
method works better with character-oriented tools that calculate
positions by distance from the beginning of the file instead of by line
number.
HerringtonDarkholme
approved these changes
Mar 2, 2017
|
This is an interesting change - one of the implications (and the reason why I used comments before) is when used with a linter that checks whitespaces or blank lines, this would raise a lot of warnings... (e.g. Maybe we can change the option to use different values, e.g. |
|
Good idea. I didn't think about the linter case. I'll change the type of pad to |
Also still supports true for backward compatibility. True is the same as "line".
sandersn
added a commit
to sandersn/vue-loader
that referenced
this pull request
Mar 3, 2017
The pad option now accepts 'line' or 'space' as padding options. Depends on vuejs/vue#5059
yyx990803
pushed a commit
to vuejs/vue-loader
that referenced
this pull request
Mar 5, 2017
The pad option now accepts 'line' or 'space' as padding options. Depends on vuejs/vue#5059
sandersn
deleted the
sfc-parseComponent-completely-pads-content-with-spaces
branch
xalexec
pushed a commit
to Transnal/vue-loader
that referenced
this pull request
Mar 26, 2017
The pad option now accepts 'line' or 'space' as padding options. Depends on vuejs/vue#5059
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SFC
parseComponentpads all content with spaces when{ pad: true }is provided. That is, all content is converted to spaces. Previously, each line was truncated to//. The new padding method works better with character-oriented tools that calculate positions by distance from the beginning of the file instead of by linenumber.
Fixes #5058.