Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sfc): do not deindent space-padded output #8724

Closed
wants to merge 1 commit into from

Conversation

ypresto
Copy link

@ypresto ypresto commented Aug 28, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

parseComponent('...', { pad: 'space' }).script.content will contain code with base indent if SFC content has base indent. Also applies to styles or etc.

As #5058 and #5059, pad: 'space' is for character-oriented tools that calculate positions by distance from the beginning of the file instead of by line. This should be applied to source code itself, so I think it was buggy and breaking change is unavoidable.

The PR fulfills these requirements:

Other information:

I'm personally creating tool to convert export default { ... } to vue-property-decorators style, so I'm using vue-template-compiler with @vue/component-compiler-utils and code with original indent is needed.

@ypresto ypresto force-pushed the sfc-parser-keep-indent branch from ee05a62 to 45e70be Compare August 28, 2018 19:13
@ktsn
Copy link
Member

ktsn commented Aug 29, 2018

#7647

@ypresto
Copy link
Author

ypresto commented Aug 29, 2018

Oh, this PR is dupe of that :P
Is that PR is likely to be merged? (looks so old...)

@yyx990803
Copy link
Member

Thanks, we will merge #7647.

@yyx990803 yyx990803 closed this Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants