fix(sfc): do not deindent space-padded output #8724
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
parseComponent('...', { pad: 'space' }).script.content
will contain code with base indent if SFC content has base indent. Also applies to styles or etc.As #5058 and #5059,
pad: 'space'
is for character-oriented tools that calculate positions by distance from the beginning of the file instead of by line. This should be applied to source code itself, so I think it was buggy and breaking change is unavoidable.The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)Other information:
I'm personally creating tool to convert
export default { ... }
tovue-property-decorators
style, so I'm usingvue-template-compiler
with@vue/component-compiler-utils
and code with original indent is needed.