Skip to content

Commit

Permalink
Merge pull request #5484 from vuestorefront/typo-in-docs
Browse files Browse the repository at this point in the history
fixed some typo in docs
  • Loading branch information
Fifciu authored Feb 5, 2021
2 parents 63f380b + 9ba4978 commit f51ad9e
Show file tree
Hide file tree
Showing 13 changed files with 73 additions and 72 deletions.
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
move pick allowed modification just before sending data to task managment
add 'beforeUserProfileUpdate' which allows to modify user object before update - gibkigonzo (#4427)
- replace lodash with lodash-es for client files - gibkigonzo (#5019)
- add default personal detail loading on shipment step in checkout when user is logged - (#5040)
- Got rid of inifnity redirect or page-not-found on refresh category/product view
- add default personal detail loading on shipment step in checkout when user is logged - (#5040)
- Got rid of inifnity redirect or page-not-found on refresh category/product view
- Got rid of memory leak related to dynamic config - tomasz-duda (#4768)
- servercart-after-diff event payload - Fifciu (#5365)
- Fix Original Price Calculation typo - @akucharczyk / @lukaszjedrasik (#5472)
### Changed / Improved

- Moved hardcoded fields from omitSelectedVariantFields.ts to config (#4679)
Expand Down
2 changes: 1 addition & 1 deletion core/modules/catalog/helpers/price/syncProductPrice.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export default function syncProductPrice (product, backProduct) { // TODO: we pr

product.price_tax = product.price_incl_tax - product.price
product.special_price_tax = product.special_price_incl_tax - product.special_price
product.original_price_tax = product.original_price_incl_tax - product.original_trice
product.original_price_tax = product.original_price_incl_tax - product.original_price

if (product.price_incl_tax >= product.original_price_incl_tax) {
product.special_price_incl_tax = 0
Expand Down
2 changes: 1 addition & 1 deletion docs/guide/basics/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Please take a look at the `node-config` docs as the library is open for some oth
:::tip NOTE
Currently, the configuration files are being processed by the webpack during the build process. This means that whenever you apply some configuration changes, you shall rebuild the app, even when using the `yarn dev` mode. This limitation can be solved with the VS 1.4 special config variable. Now the config can be reloaded on the fly with each server request if `config.server.dynamicConfigReload` and `config.server.dynamicConfigReloadWithEachRequest` are set to true. However, in that case, the config is added to `window.INITIAL_STATE` with the responses.

When you using the `config.server.dynamicConfigReload` please remember about `config.server.dynamicConfigExclude` and `config.server.dynamicConfigInclude`.
When you are using the `config.server.dynamicConfigReload` please remember about `config.server.dynamicConfigExclude` and `config.server.dynamicConfigInclude`.
:::

Please find the configuration properties reference below.
Expand Down
30 changes: 15 additions & 15 deletions docs/guide/cookbook/checklist.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/guide/cookbook/setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ This looks like by and large the same with *Vue Storefront API* with a few chang
`app` service describes options for *Vue Storefront* frontend application.
- `network_mode` allows you to modify values for `--network` option of docker client. `host` option allows your designated container to open to host network. For example, if you bind your container in host's `80` port, then the container will be accessible at host's `<IP address>:80` from the internet. In other words, the container is not isolated. [more info](https://docs.docker.com/network/host/)

If you take a closer look inside `Dockerfile`s, you will notice they install all the dependencies of the project from `package.json` not to mention required OS features including `git`, `wget` and certificates. You don't have to worry what to do because we made it do for you.
If you take a closer look inside `Dockerfile's`, you will notice they install all the dependencies of the project from `package.json` not to mention required OS features including `git`, `wget` and certificates. You don't have to worry what to do because we made it do for you.
Next, you might want to import your goods data. Please jump to [Data imports](./data-import.md) if you don't want to stop.
Expand Down
4 changes: 1 addition & 3 deletions docs/guide/core-themes/core-components.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

In Vue Storefront there are two types of components:

- In Vue Storefront there are two types of components:

- **Core components:** In core components, we implemented all basic business logic for an eCommerce shop, so you don't need to write it from scratch by yourself. You can make use of them in your themes, where all you need to do is styling and creating the HTML markup. Every core component provides an interface to interact with. This interface can be extended or overwritten in your theme if you need to. Core components should be injected to themes as mixins.They contain only business logic—HTML markup and styling should be done in themes. You can usually find core components inside the `components` folder of every module.

- **Theme components:** Theme components are what you really see in the app. They can inherit business logic from core components or be created as theme-specific components. All CSS, HTML, and ui-specific logic should be placed in theme.
Expand All @@ -14,7 +12,7 @@ In Vue Storefront there are two types of components:

First, **override core components only when you're adding ui-agnostic features to the core.** The correct approach for using core components in your theme is thinking of them as an external API. You can inherit the functionalities and extend them in theme but never change it in core.

**When you're modifying the core component, never change the component's API** (data and methods exposed by the component for themes). Such changes would break the themes using this core component.
**When you're modifying the core component, never change the component's API** (data and methods exposed by the component for themes). Such changes would break the theme using this core component.

## Using core components in your theme

Expand Down
6 changes: 3 additions & 3 deletions docs/guide/core-themes/layouts.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This feature can be very useful for non-standard rendering scenarios like:

- Generating the XML output
- Generating the AMPHTML pages
- generating widgets without `<head>` section
- Generating widgets without `<head>` section

## How it works

Expand Down Expand Up @@ -188,6 +188,6 @@ Please note that the `context` contains a lot of interesting features you can us

## Output compression

HTML Minifier has been added to Vue Storefront 1.11. To enable this feature please switch the `config.server.useHtmlMinifier`. You can set the specific configuration of the `htmlMinifier` using the `config.server.htmlMinifierOptions`. Read more on the [available configuration](https://www.npmjs.com/package/html-minifier). The minified output is tthen being cached by `SSR Output cache` mechanism.
HTML Minifier has been added to Vue Storefront 1.11. To enable this feature please switch the `config.server.useHtmlMinifier`. You can set the specific configuration of the `htmlMinifier` using the `config.server.htmlMinifierOptions`. Read more on the [available configuration](https://www.npmjs.com/package/html-minifier). The minified output is then being cached by `SSR Output cache` mechanism.

Output compression has been also enabled (if the `src/modules/server.ts` contains the `compression` module on the list). By default it works just for produdction builds. It uses the `gzip` compression by default. [Read more about the `compression` module](https://www.npmjs.com/package/compression) that we're using for this implementation.
Output compression has been also enabled (if the `src/modules/server.ts` contains the `compression` module on the list). By default it works just for production builds. It uses the `gzip` compression by default. [Read more about the `compression` module](https://www.npmjs.com/package/compression) that we're using for this implementation.
2 changes: 1 addition & 1 deletion docs/guide/core-themes/service-workers.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ The service-worker source code for `vue-storefront` is pre-compiled with Babel p

After changing anything in `{themename}/service-worker/index.js`, despite you're in `yarn dev` auto reloading mode, you need to do two things:

1.Recompile app (which regenerates service-worker):
1. Recompile app (which regenerates service-worker):
`yarn build`

2. Reload Service Worker in Dev Tools (in Chrome, just click **"Unregister"** and reload the page, and a new Service Worker will be installed).
Expand Down
4 changes: 2 additions & 2 deletions docs/guide/data-resolvers/introduction.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
## What are the data resolvers?

The `data resolvers` are the way of manage the network/api calls and split them from the rest of application. All of available `data resolvers` you can find in the `core/data-resolver` directory.
If you want to trigger a network calls, you should create a new `data resolver`, and import it in the place where it's needed.
If you want to trigger a network call, you should create a new `data resolver`, and import it in the place where it's needed.

## How to create a data resolver
First of all, please create a types for it under the namespace `DataResolver`, then just create a new data resolver like this example below:
First of all, please create a type for it under the namespace `DataResolver`, then just create a new data resolver like this example below:


```js
Expand Down
2 changes: 1 addition & 1 deletion docs/guide/data-resolvers/user-service.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Registering the new user by given user data (`customer`) and `password`.

#### `updateProfile: (userProfile: UserProfile) => Promise<Task>`

It updates the the current logged user profile (`userProfile`).
It updates the current logged user profile (`userProfile`).

#### `getProfile: () => Promise<Task>`

Expand Down
4 changes: 2 additions & 2 deletions docs/guide/general/introduction.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ We managed to do this by making extensive use of the browser cache. 
- **For the static assets** (only prod) we use the [sw-precache](https://github.com/GoogleChromeLabs/sw-precache) plugin (config can be found in `core/build/webpack.prod.sw.config.js` ). They are cached in Service Worker and can be inspected under the `Application/Cache Storage` tab of your Developer Tools.

![cache](https://cdn-images-1.medium.com/max/1200/1*BHVzt7oCIxcM3bNPZriKmw.png)
*Here you can find cached static assets. Please notice that Service Worker works only in production mode.*
*Here you can find cached static assets.*

:::warning
Please note that Service Worker works only in production mode.
Expand All @@ -116,7 +116,7 @@ You may not believe me but this is all you need to know to start working with Vu
- [Project structure explained](https://docs.vuestorefront.io/guide/basics/project-structure.html)
- [Configuration file explained](https://docs.vuestorefront.io/guide/basics/configuration.html)
- [Extending Vue Storefront](https://docs.vuestorefront.io/guide/extensions/introduction.html)
- [How to contribute](https://docs.vuestorefront.io/guide/basics/contributing.html#branches)
- [How to contribute](https://docs.vuestorefront.io/guide/basics/contributing.html#how-to-contribute)

## Video with training
You can also watch a video recording from 4th Vue Storefront hackathon with free introduction training
Expand Down
4 changes: 2 additions & 2 deletions docs/guide/integrations/multistore.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ As you can see, it's just an **IT** or **DE** store code that is added to the ba
In the result, you should get:

- _vue_storefront_catalog_it_ - populated with the "it" store data
- _vue_storefront_catalog_de_ - populated with the "it" store data
- _vue_storefront_catalog_de_ - populated with the "de" store data
- _vue_storefront_catalog_ - populated with the "default" store data

Then, to use these indices in Vue Storefront, you should index the database schema using the `vue-storefront-api` db tool (use only if using mage2vuestorefront!):
Expand Down Expand Up @@ -190,7 +190,7 @@ By default, the language / store is switched by the URL prefix:

- `http://localhost:3000` is for the default store
- `http://localhost:3000/it` will switch the store to the Italian one
- `http://localhost:3000/de` will switch the store to the German one one
- `http://localhost:3000/de` will switch the store to the German one

General URL format is:
`http://localhost:3000/{storeCode}`
Expand Down
78 changes: 40 additions & 38 deletions docs/guide/upgrade-notes/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,47 +21,49 @@ The `amp-renderer` module has been disabled by default to save the bundle size;
Cart optimization was earlier disabled automatically if entity optimization was disabled. Now they can be used independently from each other. If you don't want to use cart optimization, make sure that the `entities.optimizeShoppingCart` configuration entry is disabled explicitly.

**deprecated actions and helpers**

Product module has been refactored, here is list of actions that are not used anymore and you can remove them to reduce bundle.
deprecated actions:
product/reset
product/setupBreadcrumbs
product/syncPlatformPricesOver
product/setupAssociated
product/loadConfigurableAttributes
product/setupVariants
product/filterUnavailableVariants
product/list
product/preConfigureAssociated
product/preConfigureProduct
product/configureLoadedProducts
product/configureBundleAsync
product/configureGroupedAsync
product/configure
product/setCurrentOption
product/setCurrentErrors
product/setOriginal
product/loadProductAttributes
category/list (new action is category-next/fetchMenuCategories)

deprecated helpers:
configureProductAsync
populateProductConfigurationAsync
setConfigurableProductOptionsAsync

- deprecated actions:
- product/reset
- product/setupBreadcrumbs
- product/syncPlatformPricesOver
- product/setupAssociated
- product/loadConfigurableAttributes
- product/setupVariants
- product/filterUnavailableVariants
- product/list
- product/preConfigureAssociated
- product/preConfigureProduct
- product/configureLoadedProducts
- product/configureBundleAsync
- product/configureGroupedAsync
- product/configure
- product/setCurrentOption
- product/setCurrentErrors
- product/setOriginal
- product/loadProductAttributes
- category/list (new action is category-next/fetchMenuCategories)

- deprecated helpers:
- configureProductAsync
- populateProductConfigurationAsync
- setConfigurableProductOptionsAsync

Here is list of actions that are used from 1.12 in product module:
product/doPlatformPricesSync
product/single
product/checkConfigurableParent
product/findProducts
product/findConfigurableParent
product/setCustomOptions
product/setBundleOptions
product/setCurrent
product/loadProduct
product/addCustomOptionValidator
product/setProductGallery
product/loadProductBreadcrumbs
product/getProductVariant
- product/doPlatformPricesSync
- product/single
- product/checkConfigurableParent
- product/findProducts
- product/findConfigurableParent
- product/setCustomOptions
- product/setBundleOptions
- product/setCurrent
- product/loadProduct
- product/addCustomOptionValidator
- product/setProductGallery
- product/loadProductBreadcrumbs
- product/getProductVariant

All of those actions and helpers that are deprecated, can be removed so you will have smaller bundle.
Comment those lines:
Expand Down

0 comments on commit f51ad9e

Please sign in to comment.