Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed some typo in docs #5484

Merged
merged 3 commits into from
Feb 5, 2021
Merged

fixed some typo in docs #5484

merged 3 commits into from
Feb 5, 2021

Conversation

lukaszjedrasik
Copy link
Contributor

@lukaszjedrasik lukaszjedrasik commented Feb 4, 2021

Related Issues

closes #5472

Short Description and Why It's Useful

As we talked, I have used changes from this PR #5391

Screenshots of Visual Changes before/after (if There Are Any)

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature
  • (Next only) I've followed this instruction and I've created a .js file with information about my Pull Request

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@lukaszjedrasik lukaszjedrasik added the VSF1 Issues in regards to VSF1 label Feb 4, 2021
@lukaszjedrasik lukaszjedrasik requested a review from Fifciu February 4, 2021 08:02
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Fifciu Fifciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested

@lukaszjedrasik lukaszjedrasik requested a review from Fifciu February 4, 2021 09:33
@lukaszjedrasik
Copy link
Contributor Author

@Fifciu fixed

Copy link
Collaborator

@Fifciu Fifciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great, good job

@Fifciu Fifciu merged commit f51ad9e into hotfix/v1.12.3 Feb 5, 2021
@lukaszjedrasik lukaszjedrasik deleted the typo-in-docs branch June 22, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VSF1 Issues in regards to VSF1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants