Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some products added to Shopping cart have a price without tax in offline mode. #2997

Closed
5 tasks
alinadivante opened this issue May 31, 2019 · 3 comments
Closed
5 tasks
Labels
bug Bug reports QA approved on branch Testers will add this label after positive check on specific branch.
Milestone

Comments

@alinadivante
Copy link
Collaborator

Relates to #2896

Current behavior

Some of available products (e.g. Leah Yoga Top) added to shopping cart, display price without tax in offline mode
offline_mode

Expected behavior

The price should always be displayed with tax.

Steps to reproduce the issue

1, Add any product, for example Leah Yoga Top
2. Open Shopping cart
3. Switch to offline mode

Repository

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version:

Additional information

@alinadivante alinadivante added the bug Bug reports label May 31, 2019
pkarw added a commit that referenced this issue May 31, 2019
@pkarw pkarw added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 31, 2019
@pkarw
Copy link
Collaborator

pkarw commented May 31, 2019

Fixed on a branch #2887

@alinadivante
Copy link
Collaborator Author

alinadivante commented Jun 4, 2019

Yes, it works now.
But @pkarw please look at this:
discount
There is only a new price of product, but when I go offline I see also price before the discount.
In my opinion we should displaying previous price and after discount.
Am I right?

  1. Add to cart Joust Duffle Bag
  2. Open cart
  3. Go to offline mode

@pkarw
Copy link
Collaborator

pkarw commented Jun 4, 2019

@alinadivante yeah, it should work like this but it's not possible to implement it in a deterministic way. I mean - we get the prices from Magento backend, calculated after all the shopping cart rules. In the offline mode, we're never sure the price after discounts as they can't be calculated. Therefore it's safer to display the prices without the discount

@pkarw pkarw closed this as completed Jun 4, 2019
@pkarw pkarw added this to the 1.10.0-rc.1 milestone Jun 4, 2019
@alinadivante alinadivante added QA approved on branch Testers will add this label after positive check on specific branch. and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports QA approved on branch Testers will add this label after positive check on specific branch.
Projects
None yet
Development

No branches or pull requests

2 participants