Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the quantity of the product in the cart doesn't change its price (offline mode) #2896

Closed
2 of 5 tasks
GabiDivante opened this issue May 14, 2019 · 3 comments
Closed
2 of 5 tasks
Labels
bug Bug reports QA approved after merge Testers will add this label after positive check on merged changes QA approved on branch Testers will add this label after positive check on specific branch.
Milestone

Comments

@GabiDivante
Copy link
Collaborator

GabiDivante commented May 14, 2019

Current behavior

In offline mode, changing the quantity of the product in the cart does not change its price. Grand total is changing properly.
Gif: https://drive.google.com/file/d/1nxMzu9E0AOw-knQF3EGhUqCfjqlOI6I3/view?usp=sharing

Expected behavior

In offline mode, changing the quantity of the product in the cart change its price as well.

Steps to reproduce the issue

  1. Go to branch develop
  2. Add any product to cart
  3. Change the Qty and look at how Product price and Grand total are changing
  4. Go to offline mode
  5. Change the Qty and look at how Product price and Grand total are changing

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser: Chrome73
  • OS:Ubuntu 18.04 LTS

Additional information

This issue doesn't appear on demo. Maybe related to #2828

@GabiDivante GabiDivante added the bug Bug reports label May 14, 2019
@pkarw
Copy link
Collaborator

pkarw commented May 14, 2019

Change the Microcart/Product.vue and how it handles the offline mode

@pkarw pkarw added this to the 1.10.0-rc.1 milestone May 17, 2019
pkarw added a commit that referenced this issue May 17, 2019
@pkarw pkarw added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 17, 2019
@GabiDivante
Copy link
Collaborator Author

@pkarw Here, I have also forgotten about the order summary in the checkout - the quantity of the product is correct but the price is not.
Peek 2019-05-20 10-49

@GabiDivante GabiDivante removed the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 20, 2019
@pkarw
Copy link
Collaborator

pkarw commented May 27, 2019

Thanks! Fixed on branch #2887

@pkarw pkarw added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 27, 2019
@GabiDivante GabiDivante added QA approved on branch Testers will add this label after positive check on specific branch. and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels May 30, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Jun 11, 2019
@alinadivante alinadivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports QA approved after merge Testers will add this label after positive check on merged changes QA approved on branch Testers will add this label after positive check on specific branch.
Projects
None yet
Development

No branches or pull requests

4 participants