-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the user
vuex module
#3095
Comments
@andrzejewsky Two things to fix:
Expected results: |
starting point for this issue (it's not related directly to refactor): https://github.com/DivanteLtd/vue-storefront/blob/76211f7d036a04b6db5eda31d1402753e5c58372/core/lib/sync/task.ts#L78 |
Related: #3237 |
Please make sure you've got the proper version of |
Fixed here: #3271 everything should works now. |
What is the motivation for adding / enhancing this feature?
In order to prepare VS for 2.0 release we're refactoring some vuex modules in order to keep the good practices:
spawnNotification
),rootStore
references,data-resolveres
(as introduced in the [WIP] Refactor catalog module #2890)What are the acceptance criteria
resetPassword
,login
,register
,update
,me
,getOrdersHistory
network calls refactoed to helpers + then todata-resolvers
callback_event
event's based logic - use just thethen(helperFnc)
insteadspawnNotification
move the notifications one level higher (to the UI)rootStore
calls with thecontext
instead (for examplecontext.rootState
)history
andme
fromlogin
(it should be extremly simple) - thesessionAfterAuthorized
should be called instead - by some observer (plugin?) on the user tokenfetch
calls with Task api callsCan you complete this feature request by yourself?
Which Release Cycle state this refers to? Info for developer.
Pick one option.
develop
branch and create Pull Request2. Feature / Improvement
back todevelop
.release
branch and create Pull Request3. Stabilisation fix
back torelease
.hotfix
ormaster
branch and create Pull Request4. Hotfix
back tohotfix
.Additional information
The text was updated successfully, but these errors were encountered: