-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring user vuex module #3247
Refactoring user vuex module #3247
Conversation
Not ready yet. I'm still working on it. There are few criteria left. |
in that cases please add WIP flag at the beginning suggesting Work in progress ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just letting you know that name of the user cache collection will change (LS key stays the same). PR with naming change will probably be merged tomorrow. Looks good btw ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's on a good way - please continue and let's merge this one in shortly :)
@andrzejewsky please do change the references to |
743cc42
to
76cdcb2
Compare
OK it's ready. I didn't remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!:)
Few notes from me. Also i don't exactly get using Promise.resolve inside async methods, i asked in one of them; i'll be grateful for explanation :)
323ece9
to
b0a7e39
Compare
@patzick Done. |
It would be nice if we could also document stuff that we write in VS docs (at least briefly). One @degi is not enough to write it, maintain it and keep up with new stuff. @andrzejewsky could you please add a Data Resolvers section to docs with very brief documentation of this one? |
@filrak just added a new section about data resolvers in the docs, with the short example of how to create a new one |
I meant you should document the user data resolver that you made in a new section about data resolvers in docs. Sorry if I wasn't precise. How I see this is that "data resolvers" should be a separate category in the docs with agenda more or less like: Data resolvers
What do you think about this? ;) |
@filrak sounds good, I'll do that. |
e40542f
to
a83d8b3
Compare
@filrak Updated. Also I added docs about |
Hi @andrzejewsky is this one ready to be merged in? Have all @patzick hints from the CR been applied? |
@pkarw yes, it's ready. |
OK, @andrzejewsky next time, please "Resolve" all the comments or comment about the changnes/actions taken. We're reviewing the PRs in a group of 3-4 ppl (me, @lukeromanowicz, @filrak, @patzick) and this helps us a lot :) |
Looks good, could you just resolve conflict? |
80d545a
to
9aa5496
Compare
c7b623b
to
32a23e2
Compare
Related issues
closes #3095
Acceptance criteria
spawnNotification
move the notifications one level higher (to the UI)rootStore
calls with the context insteadhistory
andme
from loginfetch
calls with Task api callsWhich environment this relates to
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog
Contribution and currently important rules acceptance