-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #3151, #3089 and #3178 #3237
Conversation
@pkarw please give test instructions, what exactly should we check here |
VS has a mechanism for auto-refreshing the user tokens when there is a timeout. We can emulate this issue. Please log-in to VS; go to order history; go to home page; open brower dev tools -> Storage -> Local Storage -> find out the In the netowrk tab there should be whole bunch of errors and then some network requests to refrersh the token and in the end id should still work just fine - the |
@pkarw I tested this PR again on next.storefrontcloud.io (@patzick did deploy here v1.10.0-rc.1 front and api)
b) "Consumer is not authorized to access self" occurs and user is logged out. |
The question was if the current develop version of vue-storefront-api has been deployed there @patzick? This one: vuestorefront/vue-storefront-api#302 I also see some console error - @patzick can you please take a look of it? I can't handle it today |
@pkarw no, on relase is deployed release/v1.10 branch like here; i cannot deploy develop on next |
Connected to vuestorefront/vue-storefront-api#309 |
Related issues
closes #3151, #3178, #3089
Related to: vuestorefront/vue-storefront-api#302
Short description and why it's useful
I've changed the way the HTTP errors are treated in the API - now we're checking the HTTP status code instead of the message itself