Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #3151, #3089 and #3178 #3237

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Fix for #3151, #3089 and #3178 #3237

merged 2 commits into from
Jul 16, 2019

Conversation

pkarw
Copy link
Collaborator

@pkarw pkarw commented Jul 16, 2019

Related issues

closes #3151, #3178, #3089

Related to: vuestorefront/vue-storefront-api#302

Short description and why it's useful

I've changed the way the HTTP errors are treated in the API - now we're checking the HTTP status code instead of the message itself

@pkarw pkarw added this to the 1.10.0 milestone Jul 16, 2019
@pkarw pkarw requested a review from patzick July 16, 2019 08:23
@pkarw pkarw added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Jul 16, 2019
@pkarw pkarw requested a review from lukeromanowicz July 16, 2019 08:23
This is workaroundn for `cashonndelivery` being removed by `backend-payment-methods` module
@pkarw pkarw changed the title Fix for #3151 and #3178 Fix for #3151, #3089 and #3178 Jul 16, 2019
@pkarw pkarw merged commit 221eedb into release/v1.10 Jul 16, 2019
@patzick patzick deleted the bugfix/3151 branch July 16, 2019 11:39
@alinadivante
Copy link
Collaborator

@pkarw please give test instructions, what exactly should we check here

@pkarw
Copy link
Collaborator Author

pkarw commented Jul 17, 2019

VS has a mechanism for auto-refreshing the user tokens when there is a timeout. We can emulate this issue. Please log-in to VS; go to order history; go to home page; open brower dev tools -> Storage -> Local Storage -> find out the shop/user/current-token change the value to invalid-token-blablabla-greetings-from-alina-the-qa-team-:-) and go back to order history.

In the netowrk tab there should be whole bunch of errors and then some network requests to refrersh the token and in the end id should still work just fine - the shop/user/current-token should be replaced with the valid user token from Magento

@alinadivante
Copy link
Collaborator

@pkarw I tested this PR again on next.storefrontcloud.io (@patzick did deploy here v1.10.0-rc.1 front and api)
Are u sure that your changes have been merged into release1.10?
Because I see two problems:

  1. When user registers new account, there is info "You are logged in" but he isn't logged in.
    image

  2. When I change token and open again my account and refresh page- I noticed two different behavior:
    a) There is info "Consumer is not authorized to access self" but he is still logged in. And in dev-console I see shop/user/current-token - my own token ( it wasn't replaced)
    image

b) "Consumer is not authorized to access self" occurs and user is logged out. shop/user/current-token - null
image

@alinadivante alinadivante added QA rejected Testers will add this label when something is still wrong and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Jul 22, 2019
@pkarw
Copy link
Collaborator Author

pkarw commented Jul 22, 2019

The question was if the current develop version of vue-storefront-api has been deployed there @patzick? This one: vuestorefront/vue-storefront-api#302

I also see some console error - @patzick can you please take a look of it? I can't handle it today

@patzick
Copy link
Collaborator

patzick commented Jul 22, 2019

@pkarw no, on relase is deployed release/v1.10 branch like here; i cannot deploy develop on next
I'll create backported functionality do release branch in api

@patzick
Copy link
Collaborator

patzick commented Jul 22, 2019

Connected to vuestorefront/vue-storefront-api#309
deployed and ready for retests

@patzick patzick added QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. and removed QA rejected Testers will add this label when something is still wrong labels Jul 22, 2019
@pkarw pkarw mentioned this pull request Jul 23, 2019
11 tasks
@alinadivante alinadivante removed the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants