-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX CartID entity = null #2820
Closed
Closed
FIX CartID entity = null #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since now, range queries were activated only if `filter.value` contained ALL of `rangeOperators`. This logic is obviously wrong. This PR inverses the logic - we check if every `filter.value` key is one of `rangeOperators`.
fix password input icon - closes #2772
…-my-account-refresh Bugfix/multiple redirections on my account refresh
Fix range queries to elasticsearch
…and-registration-form Bugfix/switching between login and registration form
prevent push defaultStoreCode routes
…ication popup - closes #2796
…ts-failing-release-1.9 Fix Cart mutations tests
… canceled after going back to online - closes #2740
Bugfix/2793 docker problems
Fix blinking category page
…er-requests Fix stacking invalid order requests
sorry i am not familiar, did something wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
closes #2592
Short description and why it's useful
The clear cart function on microcart creates cartID token error without the added line.
Screenshots of visual changes before/after (if there are any)
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle
develop
branch and want to merge it back todevelop
release
branch and want to merge it back torelease
hotfix
ormaster
branch and want to merge it back tohotfix
Upgrade Notes and Changelog
IMPORTANT NOTICE - Remember to update
CHANGELOG.md
with description of your changeContribution and currently important rules acceptance