Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX CartID entity = null #2820

Closed
wants to merge 40 commits into from
Closed

FIX CartID entity = null #2820

wants to merge 40 commits into from

Conversation

michhy
Copy link

@michhy michhy commented Apr 26, 2019

Related issues

closes #2592

Short description and why it's useful

The clear cart function on microcart creates cartID token error without the added line.

Screenshots of visual changes before/after (if there are any)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

Oskar Laska and others added 30 commits April 17, 2019 09:52
Since now, range queries were activated only if `filter.value` contained ALL of `rangeOperators`. This logic is obviously wrong.

This PR inverses the logic - we check if every `filter.value` key is one of `rangeOperators`.
…-my-account-refresh

Bugfix/multiple redirections on my account refresh
Fix range queries to elasticsearch
…and-registration-form

Bugfix/switching between login and registration form
prevent push defaultStoreCode routes
…ts-failing-release-1.9

Fix Cart mutations tests
@michhy michhy changed the base branch from master to develop April 26, 2019 17:38
@michhy michhy closed this Apr 26, 2019
@michhy
Copy link
Author

michhy commented Apr 26, 2019

sorry i am not familiar, did something wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants