Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate the prop detailsLink #3689

Merged
merged 27 commits into from
Oct 13, 2019

Conversation

benjick
Copy link
Contributor

@benjick benjick commented Oct 6, 2019

Related issues

closes #

Short description and why it's useful

Screenshots of visual changes before/after (if there are any)

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@pkarw pkarw requested a review from andrzejewsky October 7, 2019 19:03
Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's a fix to a pretty obvious issue so I'm not sure if changelog update is required in here or not

@andrzejewsky
Copy link
Contributor

@benjick which version of VSF do you want to merge to 1.10 / 1.11?

@benjick
Copy link
Contributor Author

benjick commented Oct 8, 2019 via email

@andrzejewsky
Copy link
Contributor

@benjick Ok, could you please rebase that with release/v11.1 branch?

@andrzejewsky andrzejewsky changed the base branch from master to hotfix/v1.10.4 October 13, 2019 16:13
@andrzejewsky andrzejewsky merged commit 5c48f3e into vuestorefront:hotfix/v1.10.4 Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants