Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate the prop detailsLink #3689

Merged
merged 27 commits into from
Oct 13, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
3681d5f
[Docs] Updated cookbook/theme R1 - sidetalk added
kkdg Sep 23, 2019
2e445d3
[Docs] Updated cookbook/theme R1
kkdg Sep 24, 2019
670b06a
[Docs] Updated cookbook/theme R3 - intro
kkdg Sep 26, 2019
584f2b5
[Docs] Updated cookbook/theme R3 - intro
kkdg Sep 26, 2019
1a2d3f0
[Docs] Updated cookbook/theme R3 prep
kkdg Oct 1, 2019
9a93947
[Docs] Updated cookbook/theme commit hash
kkdg Oct 1, 2019
ed3d1ff
[Docs] Updated cookbook/theme R3 - git hash
kkdg Oct 1, 2019
9ce28b2
Improve docs
mkoszut Oct 1, 2019
542b6cb
[Docs] Updated cookbook/theme R3 - intro
kkdg Oct 1, 2019
8686c00
[Docs] Updated cookbook/theme R3 - Recipe
kkdg Oct 1, 2019
037c2a1
[Docs] Added img for cookbook/theme R3
kkdg Oct 1, 2019
ba51270
[Docs] Updated cookbook/theme R2 - change position recipe
kkdg Oct 1, 2019
8c3e0ae
[Docs] Updated cookbook/theme R2 - refining phrases
kkdg Oct 1, 2019
35d8acf
[Docs] Updated cookbook/theme R3 - done with Home.vue
kkdg Oct 1, 2019
81de617
[Docs] Updated cookbook/theme - style for borderline
kkdg Oct 2, 2019
0df31c4
[Docs] Updated cookbook/theme R2 - 1.prep update
kkdg Oct 2, 2019
ace8d2b
[Docs] Updated cookbook/theme - refine
kkdg Oct 2, 2019
43d8490
[Docs] Updated cookbook/theme R2 - 2. recipe done for examples
kkdg Oct 2, 2019
f0bc3dd
[Docs] Updated cookbook/theme R2 - 4.chef idea
kkdg Oct 2, 2019
2efcdaa
[Docs] Updated cookbook/theme R2 - image files added
kkdg Oct 2, 2019
7e73378
[Docs] Updated cookbook/theme R2 - git compare link added
kkdg Oct 2, 2019
9a3ca01
[Docs] Updated cookbook/theme R2 - added link to migration recipe
kkdg Oct 2, 2019
2860165
Update Readme
VicSob Oct 2, 2019
b453de6
Evaluate the prop detailsLink
benjick Oct 6, 2019
002d41b
resolve conflicts
andrzejewsky Oct 13, 2019
0ebb6da
update changelog
andrzejewsky Oct 13, 2019
6e85013
Merge branch 'hotfix/v1.10.4' into patch-2
andrzejewsky Oct 13, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed hash in dynamically resolved urls causing resolving issues - @lukeromanowicz (#3515)
- `localizedRoute()` now supports path (and prefers over fullPath) in LocalizedRoute objects - @lukeromanowicz (#3515)
- Decreased the `localStorage` quota usage + error handling by introducing new config variables: `config.products.disablePersistentProductsCache` to not store products by SKU (by default it's on). Products are cached in ServiceWorker cache anyway so the `product/list` will populate the in-memory cache (`cache.setItem(..., memoryOnly = true)`); `config.seo.disableUrlRoutesPersistentCache` - to not store the url mappings; they're stored in in-memory cache anyway so no additional requests will be made to the backend for url mapping; however it might cause some issues with url routing in the offline mode (when the offline mode PWA installed on homescreen got reloaded, the in-memory cache will be cleared so there won't potentially be the url mappings; however the same like with `product/list` the ServiceWorker cache SHOULD populate url mappings anyway); `config.syncTasks.disablePersistentTaskQueue` to not store the network requests queue in service worker. Currently only the stock-check and user-data changes were using this queue. The only downside it introuces can be related to the offline mode and these tasks will not be re-executed after connectivity established, but just in a case when the page got reloaded while offline (yeah it might happen using ServiceWorker; `syncTasks` can't be re-populated in cache from SW) - @pkarw (#2985)
- Fixed evaluate detailsLink in the cookie notification - @benjick (#3689)

## [1.10.3] - 2019.09.18

Expand Down
2 changes: 1 addition & 1 deletion src/themes/default/components/core/CookieNotification.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<span class="pr5">
{{ message }}
</span>
<router-link :to="localizedRoute('detailsLink')" :title="detailsLinkText" class="cl-bg-tertiary">
<router-link :to="localizedRoute(detailsLink)" :title="detailsLinkText" class="cl-bg-tertiary">
{{ detailsLinkText }}
</router-link>
</div>
Expand Down