Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] improve nested grid gutters #11408

Closed
ThomasKientz opened this issue May 14, 2020 · 7 comments
Closed

[Feature Request] improve nested grid gutters #11408

ThomasKientz opened this issue May 14, 2020 · 7 comments
Assignees
Labels
C: VGrid Covers issues involving VContainer, VLayout, VFlex T: bug Functionality that does not work as intended/expected
Milestone

Comments

@ThomasKientz
Copy link
Contributor

Environment

Vuetify Version: 2.2.28
Vue Version: 2.6.11
Browsers: Chrome 81.0.4044.129
OS: Mac OS 10.15.3

Steps to reproduce

Nest a grid inside another.

Expected Behavior

The gutters to remain the same between all columns of all grids.

Actual Behavior

Gutters around columns of the nested grid are larger.

Reproduction Link

https://codepen.io/thomaskientz/pen/qBOMdpY

@ghost ghost added the S: triage label May 14, 2020
@jacekkarczmarczyk jacekkarczmarczyk added the C: VGrid Covers issues involving VContainer, VLayout, VFlex label May 14, 2020
@uodami

This comment has been minimized.

@ThomasKientz

This comment has been minimized.

@johnleider johnleider added T: feature A new feature and removed S: triage labels Dec 16, 2020
@johnleider johnleider changed the title [Bug Report] Nested grids gutters issue [Feature Request] improve nested grid gutters Dec 16, 2020
@johnleider johnleider added this to the v3.x.x milestone Dec 16, 2020
@KaelWD KaelWD modified the milestones: v3.x.x, v3.0.0 Dec 22, 2020
KaelWD added a commit that referenced this issue Dec 22, 2020
@KaelWD KaelWD modified the milestones: v3.0.0, v2.4.0 Dec 23, 2020
KaelWD added a commit that referenced this issue Dec 23, 2020
fixes #11408

(cherry picked from commit c3ba5bd)
@KaelWD KaelWD closed this as completed Dec 23, 2020
@halimb
Copy link

halimb commented Jan 18, 2021

this is a breaking change, in a non major release, especially with such a central component as v-row, production applications layouts will be broken...

I'm asking, what's the quick workaround for this, instead of going through all the v-rows in my app to restore the original vertical spacing?

@Jaffsterz
Copy link

Yes it's a nightmare - we have a very large number of pages and they were all wrecked by this change.

Nobody responded to my raising it in my post above though so we have had to spend many hours going through all the pages and fixing them.

@halimb
Copy link

halimb commented Jan 18, 2021

For anyone having a busy Monday debugging this, here's a quick and dirty fix :

/**
 * Temporary fix for breaking change in Vuetify v-grid
 * (see : https://github.com/vuetifyjs/vuetify/issues/11408)
 * TODO - remove this after migration
 */
.row:not([class*="my-"]):not([class*="ma-"]):not([class*="mt-"]):not([class*="mb-"]) {
  margin-top: 0 !important;
  margin-bottom: 0 !important;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VGrid Covers issues involving VContainer, VLayout, VFlex T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

7 participants