Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Halved gutter width between v-rows #12915

Closed
Shinigami92 opened this issue Jan 7, 2021 · 4 comments · Fixed by #12916, elirehema/nbs-web#87 or elirehema/authx#10
Closed

[Bug Report] Halved gutter width between v-rows #12915

Shinigami92 opened this issue Jan 7, 2021 · 4 comments · Fixed by #12916, elirehema/nbs-web#87 or elirehema/authx#10
Assignees
Labels
C: VGrid Covers issues involving VContainer, VLayout, VFlex T: bug Functionality that does not work as intended/expected
Milestone

Comments

@Shinigami92
Copy link
Contributor

Environment

Vuetify Version: 2.4.0
Vue Version: 2.6.12
Browsers: Chrome 87.0.4280.88
OS: Linux x86_64

Steps to reproduce

After the breaking change in 2.4.0 all layouts with nested dense v-rows are kinda broken.

Current workaround is to remove the pt-0 and pb-0 in the nested v-col and then add a pt-1 in each v-row

This is just one breaking example and I would have around 80 more files to check with maybe some more complex layout issues.

Expected Behavior

Working as in 2.3.23

Actual Behavior

Has a workaround, but I want to ask if this is going to be re-worked and should I wait for more bug fixes or if I am now revising ~80 files in my project

Reproduction Link

https://codepen.io/shinigami92/pen/RwGJxvG

Other comments

#11408 (comment)

@ghost ghost added the S: triage label Jan 7, 2021
@KaelWD
Copy link
Member

KaelWD commented Jan 7, 2021

Was this just a workaround for #11408? As I said in #12848, workarounds generally need to be removed when the underlying bug is fixed, particularly when it comes to CSS.

add a pt-1 in each v-row

What's this supposed to do?

@Shinigami92
Copy link
Contributor Author

I have made 3 screenshots
So on the first screenshot you can see that everything is normal and working
After just updating the top and first vertical gutter of the outer row are both smaller
This can be fixed with adding pt-1 to both v-row
Also the right top 2 v-col in the nested v-row don't need their pt-0 and pb-0 now

Screenshot 1 and 3 are visually equivalent


Yes I think it was a workaround for #11408
I didn't saw #12848 before, I will have a look into it and maybe try some of these css global workarounds 🤔

2.3

Dashboard-2 3

2.4 broken

adSoul-Dashboard-2 4-broken

2.4 workaround

adSoul-Dashboard-2 4-workaround

@KaelWD
Copy link
Member

KaelWD commented Jan 7, 2021

Oh right, there's another bug where the space between v-rows is halved. If I fix that you won't need any CSS workarounds, just remove the pt-0/pb-0 ones.

@KaelWD KaelWD changed the title [Bug Report] Nested dense grid layout broken with 2.4 [Bug Report] Halved gutter width between v-rows Jan 7, 2021
@KaelWD KaelWD self-assigned this Jan 7, 2021
@KaelWD KaelWD added C: VGrid Covers issues involving VContainer, VLayout, VFlex T: bug Functionality that does not work as intended/expected and removed S: triage labels Jan 7, 2021
@KaelWD KaelWD added this to the v2.4.x milestone Jan 7, 2021
@Shinigami92
Copy link
Contributor Author

Perfect 👍
So I will wait for the next update, thanks
You can close this issue if you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment