-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VMenu): allow more than 1 content node #10525
Merged
KaelWD
merged 3 commits into
master
from
fix/#10522-menu-allow-more-than-1-content-node
Feb 12, 2020
Merged
fix(VMenu): allow more than 1 content node #10525
KaelWD
merged 3 commits into
master
from
fix/#10522-menu-allow-more-than-1-content-node
Feb 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacekkarczmarczyk
added
T: bug
Functionality that does not work as intended/expected
C: VMenu
VMenu
labels
Feb 9, 2020
8 tasks
Looks good to me, would like a final approval from @KaelWD since it has to do with his previous commit. |
johnleider
approved these changes
Feb 11, 2020
KaelWD
approved these changes
Feb 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um yeah I made some big changes to this PR so I was expecting someone else to review it.
Logikgate
pushed a commit
to flypapertech/vuetify
that referenced
this pull request
Feb 19, 2020
* fix(VMenu): allow more than 1 content node fixes vuetifyjs#10522 * test * fix(VMenu): show transitions Co-authored-by: Kael <kaelwd@gmail.com>
whoistobias
pushed a commit
to whoistobias/vuetify
that referenced
this pull request
Feb 26, 2020
* fix(VMenu): allow more than 1 content node fixes vuetifyjs#10522 * test * fix(VMenu): show transitions Co-authored-by: Kael <kaelwd@gmail.com>
This was referenced Mar 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
fixes #10522
related cc17fe1
How Has This Been Tested?
playground, unit
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).