Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VMenu): allow more than 1 content node #10525

Merged
merged 3 commits into from
Feb 12, 2020

Conversation

jacekkarczmarczyk
Copy link
Member

@jacekkarczmarczyk jacekkarczmarczyk commented Feb 9, 2020

Motivation and Context

fixes #10522

related cc17fe1

How Has This Been Tested?

playground, unit

Markup:

<template>
  <v-container>
    <v-subheader>VEditDialog</v-subheader>
    <v-edit-dialog large>
      <template #input><span>foo</span><span>bar</span></template>
      <span>foo</span><span>bar</span>
    </v-edit-dialog>

    <v-subheader>VMenu</v-subheader>
    <v-menu
      offset-y
      content-class="white"
    >
      <template #activator="{ on }">
        <v-btn v-on="on">Menu</v-btn>
      </template>
      <div>Foo</div>
      <div>Bar</div>
    </v-menu>

    <v-subheader>VTooltip</v-subheader>
    <v-tooltip bottom>
      <template #activator="{ on }">
        <v-btn v-on="on">Tooltip</v-btn>
      </template>
      <div>Foo</div>
      <div>Bar</div>
    </v-tooltip>

    <v-subheader>VWindow</v-subheader>
    <v-window>
      <v-window-item>
        <span>foo</span>
        <span>bar</span>
      </v-window-item>
    </v-window>

    <v-subheader>VExpansionPanels</v-subheader>
    <v-expansion-panels>
      <v-expansion-panel>
        <v-expansion-panel-header>
          <span>foo</span><span>bar</span>
        </v-expansion-panel-header>
        <v-expansion-panel-content>
          <span>foo</span><span>bar</span>
        </v-expansion-panel-content>
      </v-expansion-panel>
    </v-expansion-panels>

    <v-subheader>VCarousel</v-subheader>
    <v-carousel height="100">
      <v-carousel-item>
        <span>foo</span>
        <span>bar</span>
      </v-carousel-item>
    </v-carousel>

    <v-subheader>VListGroup</v-subheader>
    <v-list>
      <v-list-group>
        <template v-slot:activator>
          <v-list-item-content>
            <v-list-item-title>foo</v-list-item-title>
          </v-list-item-content>
        </template>
        <v-list-item>bar</v-list-item>
        <v-list-item>baz</v-list-item>
      </v-list-group>
    </v-list>
  </v-container>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added T: bug Functionality that does not work as intended/expected C: VMenu VMenu labels Feb 9, 2020
@jacekkarczmarczyk jacekkarczmarczyk added this to the v2.2.x milestone Feb 9, 2020
@johnleider
Copy link
Member

Looks good to me, would like a final approval from @KaelWD since it has to do with his previous commit.

Copy link
Member

@KaelWD KaelWD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um yeah I made some big changes to this PR so I was expecting someone else to review it.

@KaelWD KaelWD merged commit 5d8d487 into master Feb 12, 2020
@KaelWD KaelWD deleted the fix/#10522-menu-allow-more-than-1-content-node branch February 12, 2020 04:57
Logikgate pushed a commit to flypapertech/vuetify that referenced this pull request Feb 19, 2020
* fix(VMenu): allow more than 1 content node

fixes vuetifyjs#10522

* test

* fix(VMenu): show transitions

Co-authored-by: Kael <kaelwd@gmail.com>
whoistobias pushed a commit to whoistobias/vuetify that referenced this pull request Feb 26, 2020
* fix(VMenu): allow more than 1 content node

fixes vuetifyjs#10522

* test

* fix(VMenu): show transitions

Co-authored-by: Kael <kaelwd@gmail.com>
@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VMenu VMenu T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] v-menu no longer rendering all the v-lists
3 participants