Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VMenu): allow more than 1 content node #10525

Merged
merged 3 commits into from
Feb 12, 2020
Merged

fix(VMenu): allow more than 1 content node #10525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9f26cd
fix(VMenu): allow more than 1 content node
jacekkarczmarczyk Feb 9, 2020
a547958
test
jacekkarczmarczyk Feb 9, 2020
3f1c750
fix(VMenu): show transitions
KaelWD Feb 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vuetify/src/components/VAutocomplete/__tests__/VAutocomplete2.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ describe('VAutocomplete.ts', () => {
it('should propagate content class', () => {
const wrapper = mountFunction({
propsData: {
menuProps: { contentClass: 'foobar' },
menuProps: { contentClass: 'foobar', eager: true },
},
})

Expand Down
16 changes: 8 additions & 8 deletions ...ges/vuetify/src/components/VDataIterator/__tests__/__snapshots__/VDataFooter.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ exports[`VDataFooter.ts should disable last page button if no items 1`] = `
<div role="button"
aria-haspopup="listbox"
aria-expanded="false"
aria-owns="list-60"
aria-owns="list-55"
class="v-input__slot"
>
<div class="v-select__slot">
Expand All @@ -18,7 +18,7 @@ exports[`VDataFooter.ts should disable last page button if no items 1`] = `
10
</div>
<input aria-label="$vuetify.dataFooter.itemsPerPageText"
id="input-60"
id="input-55"
readonly="readonly"
type="text"
aria-readonly="false"
Expand Down Expand Up @@ -110,7 +110,7 @@ exports[`VDataFooter.ts should render first & last icons with showFirstLastPage
<div role="button"
aria-haspopup="listbox"
aria-expanded="false"
aria-owns="list-26"
aria-owns="list-24"
class="v-input__slot"
>
<div class="v-select__slot">
Expand All @@ -119,7 +119,7 @@ exports[`VDataFooter.ts should render first & last icons with showFirstLastPage
10
</div>
<input aria-label="$vuetify.dataFooter.itemsPerPageText"
id="input-26"
id="input-24"
readonly="readonly"
type="text"
aria-readonly="false"
Expand Down Expand Up @@ -207,7 +207,7 @@ exports[`VDataFooter.ts should render in RTL mode 1`] = `
<div role="button"
aria-haspopup="listbox"
aria-expanded="false"
aria-owns="list-12"
aria-owns="list-11"
class="v-input__slot"
>
<div class="v-select__slot">
Expand All @@ -216,7 +216,7 @@ exports[`VDataFooter.ts should render in RTL mode 1`] = `
10
</div>
<input aria-label="$vuetify.dataFooter.itemsPerPageText"
id="input-12"
id="input-11"
readonly="readonly"
type="text"
aria-readonly="false"
Expand Down Expand Up @@ -380,7 +380,7 @@ exports[`VDataFooter.ts should show current page if has showCurrentPage 1`] = `
<div role="button"
aria-haspopup="listbox"
aria-expanded="false"
aria-owns="list-50"
aria-owns="list-46"
class="v-input__slot"
>
<div class="v-select__slot">
Expand All @@ -389,7 +389,7 @@ exports[`VDataFooter.ts should show current page if has showCurrentPage 1`] = `
10
</div>
<input aria-label="$vuetify.dataFooter.itemsPerPageText"
id="input-50"
id="input-46"
readonly="readonly"
type="text"
aria-readonly="false"
Expand Down
16 changes: 8 additions & 8 deletions ...s/vuetify/src/components/VDataIterator/__tests__/__snapshots__/VDataIterator.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ exports[`VDataIterator.ts should render and match snapshot with data 1`] = `
<div role="button"
aria-haspopup="listbox"
aria-expanded="false"
aria-owns="list-17"
aria-owns="list-16"
class="v-input__slot"
>
<div class="v-select__slot">
Expand All @@ -121,7 +121,7 @@ exports[`VDataIterator.ts should render and match snapshot with data 1`] = `
10
</div>
<input aria-label="$vuetify.dataFooter.itemsPerPageText"
id="input-17"
id="input-16"
readonly="readonly"
type="text"
aria-readonly="false"
Expand Down Expand Up @@ -194,7 +194,7 @@ exports[`VDataIterator.ts should render valid no-data, loading and no-results st
<div role="button"
aria-haspopup="listbox"
aria-expanded="false"
aria-owns="list-29"
aria-owns="list-27"
class="v-input__slot"
>
<div class="v-select__slot">
Expand All @@ -203,7 +203,7 @@ exports[`VDataIterator.ts should render valid no-data, loading and no-results st
10
</div>
<input aria-label="$vuetify.dataFooter.itemsPerPageText"
id="input-29"
id="input-27"
readonly="readonly"
type="text"
aria-readonly="false"
Expand Down Expand Up @@ -276,7 +276,7 @@ exports[`VDataIterator.ts should render valid no-data, loading and no-results st
<div role="button"
aria-haspopup="listbox"
aria-expanded="false"
aria-owns="list-29"
aria-owns="list-27"
class="v-input__slot"
>
<div class="v-select__slot">
Expand All @@ -285,7 +285,7 @@ exports[`VDataIterator.ts should render valid no-data, loading and no-results st
10
</div>
<input aria-label="$vuetify.dataFooter.itemsPerPageText"
id="input-29"
id="input-27"
readonly="readonly"
type="text"
aria-readonly="false"
Expand Down Expand Up @@ -358,7 +358,7 @@ exports[`VDataIterator.ts should render valid no-data, loading and no-results st
<div role="button"
aria-haspopup="listbox"
aria-expanded="false"
aria-owns="list-29"
aria-owns="list-27"
class="v-input__slot"
>
<div class="v-select__slot">
Expand All @@ -367,7 +367,7 @@ exports[`VDataIterator.ts should render valid no-data, loading and no-results st
10
</div>
<input aria-label="$vuetify.dataFooter.itemsPerPageText"
id="input-29"
id="input-27"
readonly="readonly"
type="text"
aria-readonly="false"
Expand Down
Loading