Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V-Menu] Use always display: block; #4546

Closed
wants to merge 1 commit into from
Closed

[V-Menu] Use always display: block; #4546

wants to merge 1 commit into from

Conversation

ebisbe
Copy link
Contributor

@ebisbe ebisbe commented Jul 9, 2018

Description

Fixes #3645

Motivation and Context

Styles issues with the v-menu component

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have created a PR in the documentation with the necessary changes.

@jacekkarczmarczyk
Copy link
Member

It fails when you need your menu to be displayed inline (not sure if this is a common case though)

<template>
  <v-app id="inspire">
    <v-content>
      Hello
      <v-menu>
        <v-btn slot="activator">Show menu</v-btn>
        <v-card><v-card-text>Hello world!</v-card-text></v-card>
      </v-menu>
      world
    </v-content>
  </v-app>
</template>

Probably this will be the best fix for it when it's implemented #3206

@johnleider
Copy link
Member

There is a prop that turns v-menu into block called full-width.

Thank you for your contribution though!

@lock
Copy link

lock bot commented Apr 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] "display: inline-block" CSS property on <v-menu> component
3 participants