Add support for configurable paginator on top of search results. #3034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mink tests are passing for me. |
demiankatz
requested changes
Aug 16, 2023
module/VuFind/tests/integration-tests/src/VuFindTest/Mink/BasicSearchTest.php
Outdated
Show resolved
Hide resolved
…ufind-org#3032) This paves way for extended use (i.e. the possibility of rendering search results without the surrounding controls).
demiankatz
requested changes
Aug 16, 2023
There was a problem hiding this comment.
Thanks for the progress, and I agree that adding more configuration to hide the bottom paginator is probably not necessary at this point (and could be added in future if there's a compelling need). Just one small question that arose when I looked more closely at the Mink tests.
module/VuFind/tests/integration-tests/src/VuFindTest/Mink/BasicSearchTest.php
Outdated
Show resolved
Hide resolved
demiankatz
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Thanks, @EreMaijala -- looks good to me now, and all Mink tests are still passing in my environment.
EreMaijala
added a commit
to EreMaijala/vufind
that referenced
this pull request
Oct 8, 2024
* Add scss support for finna2 theme. * Add scss support to custom theme. * Update feed.scss * Add finna:lessToSass and finna:scss Grunt tasks. Also switches to include paths for font-awesome and Bootstrap to avoid deprecation warnings. * Switch checkSassBuild and checkLessToSass to Finna versions. * Fix bad less change for font-awesome path. * Make sure declarations come before nested rules This fixes sass deprecations. * Fix adding !default in lessToSass * Write css to temp dir with finna:check:scss * Fix custom theme finna.scss to include variables and custom files. * Update bootstrap3 scss Font Awesome to version 4.7.0 (vufind-org#3958) When the less version was updated, the scss version was accidentally left at version 4.6.3, which is missing some icons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2929.