Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi facet selection - Record last user state #4109

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

rominail
Copy link
Contributor

For the multi facets js selection, record user choice in local storage

themes/bootstrap3/js/facets.js Outdated Show resolved Hide resolved
themes/bootstrap3/js/facets.js Outdated Show resolved Hide resolved
themes/bootstrap3/js/facets.js Outdated Show resolved Hide resolved
themes/bootstrap3/js/facets.js Show resolved Hide resolved
@rominail rominail force-pushed the multiFacetsSelection branch from ec04495 to c17d041 Compare December 2, 2024 16:16
@demiankatz demiankatz requested a review from EreMaijala December 2, 2024 16:32
themes/bootstrap3/js/facets.js Outdated Show resolved Hide resolved
@rominail rominail requested a review from EreMaijala December 4, 2024 19:26
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EreMaijala, are tests passing for you? Mine are consistently failing with:

There were 2 failures:

1) VuFindTest\Mink\SearchFacetsTest::testCheckboxFacetSelection with data set "select one (multi/single)" (['Books'], 8, true, false)
Failed asserting that 'Showing 1 - 8 results of 8' [ASCII](length: 26) contains "Showing 1 - 19 results" [ASCII](length: 22).

/usr/local/vufind/module/VuFind/tests/integration-tests/src/VuFindTest/Mink/SearchFacetsTest.php:1224

2) VuFindTest\Mink\SearchFacetsTest::testCheckboxFacetSelection with data set "select two (multi/single)" (['Books', 'Fiction'], 7, true, false)
Failed asserting that 'Showing 1 - 7 results of 7' [ASCII](length: 26) contains "Showing 1 - 19 results" [ASCII](length: 22).

/usr/local/vufind/module/VuFind/tests/integration-tests/src/VuFindTest/Mink/SearchFacetsTest.php:1224

I haven't taken a close look at why this might be -- not sure if it's a bug in the code or in the test, assuming it's not just a local glitch.

Please let me know if you need me to do more investigation on my end; I thought it would be helpful to get a second opinion before diving in too deep!

@EreMaijala
Copy link
Contributor

@demiankatz Oops, I failed to consider the tests. They will obviously need to be updated because they assume multi-selection is inactive on each page load.

@demiankatz
Copy link
Member

@rominail, are you interested in trying to figure this out, or do you want help? (I don't think you've worked with the test suite before, so I'm happy to help if you don't have time to dive in at the moment -- but if you're interested in learning, this might be a good opportunity to do so).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants