New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UB in `push_constants` #2220

Merged

Rua merged 1 commit into vulkano-rs:master from marc0246:push-constants-ub

Jun 8, 2023

Contributor

marc0246 commented Jun 3, 2023

This was made UB in #2132. Oop.

Changelog:

### Bugs fixed
- Fixed UB in `{AutoCommandBufferBuilder, UnsafeCommandBufferBuilder}::push_constants` where a reference to uninitialized bytes could have been created.


          Fix UB in push_constants

63c36ec

Rua merged commit eb97cf2 into vulkano-rs:master

marc0246 deleted the push-constants-ub branch

June 8, 2023 09:10

Rua mentioned this pull request

Prevent panic on overflow in validate_push_constants #2232

Merged

hakolao pushed a commit to hakolao/vulkano that referenced this pull request


          Fix UB in push_constants (vulkano-rs#2220)

c4febfc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet