Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent panic on overflow in validate_push_constants #2232

Merged
merged 1 commit into from
Jun 17, 2023

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Jun 17, 2023

Fixes a small problem left by #2220.

@marc0246
Copy link
Contributor

Would you like to do the same for UnsafeCommandBufferBuilder::push_constants for consistency?

@Rua
Copy link
Contributor Author

Rua commented Jun 17, 2023

Since that's an unsafe function, I think it's ok for it to just panic if the user provides something too large.

@marc0246 marc0246 merged commit c5aa3f3 into vulkano-rs:master Jun 17, 2023
@Rua Rua deleted the push-constants-fix branch October 25, 2023 14:25
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants