Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidationError-ify commands, add some validation to UnsafeCommandBufferBuilder #2266

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Jul 21, 2023

Changelog:

### Breaking changes
Changes to command buffers:
- All validated binding and dynamic state commands now return `Result` instead of panicking, just like the other commands.
- The `begin_render_pass`, `next_subpass` and `end_render_pass` commands now take `SubpassBeginInfo` and/or `SubpassEndInfo` parameters. Nothing has changed functionally, but this allows for future-compatibility.
- `UnsafeCommandBufferBuilder` now performs some validation, when it does not rely on tracking any state. The old, completely unvalidated commands have been renamed with `_unchecked` added to the end.

Changes to `Format`:
- The `type_color`, `type_depth` and `type_stencil` methods are renamed to `numeric_format_color`, `numeric_format_depth` and `numeric_format_stencil`, and the returned type is renamed to `NumericFormat`.
- `ShaderScalarType` is renamed to `NumericType`.

@Rua Rua mentioned this pull request Jul 24, 2023
@marc0246
Copy link
Contributor

marc0246 commented Aug 4, 2023

LGTM!

@marc0246 marc0246 merged commit d0144c2 into vulkano-rs:master Aug 4, 2023
marc0246 added a commit that referenced this pull request Aug 4, 2023
@Rua Rua deleted the cb-command-validation branch October 25, 2023 14:25
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
…fferBuilder` (vulkano-rs#2266)

* ValidationError-ify commands, add some validation to `UnsafeCommandBufferBuilder`

* Use `SubpassBeginInfo` for the triangle example
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants