Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidationError-ify queries #2270

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Jul 24, 2023

Changelog:

### Breaking changes
Changes to queries:
- `Query` and `QueriesRange` are removed. The `get_results` method is moved to `QueryPool` directly.

Depends on #2266.

@Rua Rua changed the title Query validation ValidationError-ify queries Jul 24, 2023
@marc0246
Copy link
Contributor

marc0246 commented Aug 4, 2023

Yes hello, I'd like to order one rebase please.

Copy link
Contributor

@marc0246 marc0246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marc0246 marc0246 merged commit fefb3b8 into vulkano-rs:master Aug 4, 2023
marc0246 added a commit that referenced this pull request Aug 4, 2023
@Rua Rua deleted the query-validation branch October 25, 2023 14:24
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
* ValidationError-ify commands, add some validation to `UnsafeCommandBufferBuilder`

* Use `SubpassBeginInfo` for the triangle example

* ValidationError-ify queries
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants