Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove base64 encoding of user data on create #100

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Remove base64 encoding of user data on create #100

merged 1 commit into from
Nov 2, 2020

Conversation

nsmith5
Copy link
Contributor

@nsmith5 nsmith5 commented Oct 31, 2020

Description

Don't not base64 encode userdata on server and bare-metal creation. This matches behaviour from #73.

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

Matches the behaviour from update and fixes issues in
terraform-vultr-provider.
@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #100 into master will decrease coverage by 2.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   72.00%   69.24%   -2.77%     
==========================================
  Files          24       24              
  Lines        2704     2461     -243     
==========================================
- Hits         1947     1704     -243     
  Misses        381      381              
  Partials      376      376              
Impacted Files Coverage Δ
bare_metal_server.go 71.34% <100.00%> (-2.79%) ⬇️
server.go 68.25% <100.00%> (-3.04%) ⬇️
application.go 63.63% <0.00%> (-5.60%) ⬇️
plans.go 66.10% <0.00%> (-4.92%) ⬇️
iso.go 62.79% <0.00%> (-4.56%) ⬇️
api.go 55.55% <0.00%> (-4.45%) ⬇️
account.go 55.55% <0.00%> (-4.45%) ⬇️
regions.go 64.70% <0.00%> (-4.26%) ⬇️
os.go 57.14% <0.00%> (-4.15%) ⬇️
backup.go 69.23% <0.00%> (-4.11%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf76562...110c878. Read the comment docs.

@ddymko ddymko self-requested a review October 31, 2020 19:10
Copy link
Contributor

@ddymko ddymko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a fix for this! I'll tag and cut a release for this later today

@ddymko ddymko merged commit a7037bf into vultr:master Nov 2, 2020
@nsmith5 nsmith5 deleted the bugfix/base64-encoded-userdata branch November 2, 2020 17:50
@ddymko ddymko mentioned this pull request Nov 3, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants