Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove encoding for user data input #73

Merged
merged 1 commit into from
Aug 22, 2020

Conversation

mamclaughlin
Copy link
Contributor

Description

Removes the userdata encoding on govultr side and allows instead for the vultr api to error handle if an unencoded string is passed. Affects baremetal userdata and instance user data

Related Issues

Supports #71

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@mamclaughlin mamclaughlin requested a review from ddymko August 21, 2020 13:34
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #73 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   72.09%   72.07%   -0.03%     
==========================================
  Files          24       24              
  Lines        2684     2682       -2     
==========================================
- Hits         1935     1933       -2     
  Misses        377      377              
  Partials      372      372              
Impacted Files Coverage Δ
bare_metal_server.go 74.12% <100.00%> (-0.07%) ⬇️
server.go 71.56% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49fc55b...5e6ad07. Read the comment docs.

@ddymko ddymko linked an issue Aug 21, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] - UserData calls should take in encoded value
2 participants