T3420: Remove service upnp #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `service upnp` as it never worked as expected, nft rules do not integrated and custom patches do not seem like a suitable solution for now. Security: UPnP has been historically associated with security risks due to its automatic and potentially unauthenticated nature. UPnP devices might be vulnerable to unauthorized access or exploitation.
sever-sever
requested review from
a team,
dmbaturin,
sarthurdev,
zdc,
jestabro and
c-po
and removed request for
a team
11 tasks
dmbaturin
approved these changes
May 14, 2024
|
Backport to sagitta? |
|
@Mergifyio backport sagitta |
✅ Backports have been created
|
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Remove
service upnpas it never worked as expected, NFT rules are not integrated, and custom patches do not seem like a suitable solution for now.Security:
UPnP has been historically associated with security risks due to its automatic and potentially unauthenticated nature.
UPnP devices might be vulnerable to unauthorized access or exploitation.
Types of changes
Related Task(s)
Related PR(s)
vyos/vyos-build#618
Component(s) name
upnp
Proposed changes
How to test
Smoketest result
Checklist: