T3420: Remove service upnp (backport #3452) #3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
12 tasks
sever-sever
requested review from
sever-sever,
a team,
dmbaturin,
sarthurdev,
zdc,
jestabro and
c-po
and removed request for
a team
sever-sever
force-pushed
the
mergify/bp/sagitta/pr-3452
branch
2 times, most recently
from
e771440
to
bb0b1b7
Compare
Remove `service upnp` as it never worked as expected, nft rules do not integrated and custom patches do not seem like a suitable solution for now. Security: UPnP has been historically associated with security risks due to its automatic and potentially unauthenticated nature. UPnP devices might be vulnerable to unauthorized access or exploitation. (cherry picked from commit 7c438ca)
sever-sever
force-pushed
the
mergify/bp/sagitta/pr-3452
branch
from
bb0b1b7
to
f844b28
Compare
sever-sever
approved these changes
May 14, 2024
c-po
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Remove
service upnpas it never worked as expected, NFT rules are not integrated, and custom patches do not seem like a suitable solution for now.Security:
UPnP has been historically associated with security risks due to its automatic and potentially unauthenticated nature.
UPnP devices might be vulnerable to unauthorized access or exploitation.
Types of changes
Related Task(s)
Related PR(s)
vyos/vyos-build#618
Component(s) name
upnp
Proposed changes
How to test
Smoketest result
Checklist:
This is an automatic backport of pull request #3452 done by [Mergify](https://mergify.com).