feat: more arithmetic optimizations #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-cooper
force-pushed
the
rewrite_optimizer3
branch
2 times, most recently
from
cdca867 to
4e71f13
Compare
|
This pull request introduces 1 alert when merging 38bdfad into 43f491f - view on LGTM.com new alerts:
|
charles-cooper
force-pushed
the
rewrite_optimizer3
branch
from
a6d5b6a to
885b245
Compare
Merged
so caller can delegate the checking
charles-cooper
force-pushed
the
rewrite_optimizer3
branch
from
aa1421d to
abfadc7
Compare
|
This pull request introduces 11 alerts when merging abfadc7 into 4d32d17 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #2647 +/- ##
==========================================
+ Coverage 87.50% 87.58% +0.07%
==========================================
Files 94 94
Lines 10118 10158 +40
Branches 2491 2506 +15
==========================================
+ Hits 8854 8897 +43
+ Misses 801 792 -9
- Partials 463 469 +6
Continue to review full report at Codecov.
|
this is a small rewrite of the IR optimizer. it changes the structure of the binop optimizations so that it is easier to add more optimizations. it also refactors the `clamp` optimizations to be in terms of an `assert` statement, so that the clamp conditions can be optimized using the binop optimizer code.
charles-cooper
force-pushed
the
rewrite_optimizer3
branch
from
abfadc7 to
8e6309b
Compare
they are pretty much semantically the same now
replaced with a utility codegen routine
it can backfire if the condition already has an iszero in it, e.g.
```
if (iszero x) {if_branch} {else_branch}
```
would get rewritten to
```
if (iszero (iszero x)) {else_branch} {if_branch}
```
which still has an iszero in the final assembly!
optimizations for `sub` are probably better.
fubuloubu
approved these changes
May 9, 2022
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
fubuloubu
approved these changes
May 10, 2022
charles-cooper
changed the title
tserg
added a commit
to tserg/vyper
that referenced
this pull request
May 13, 2022
this is a small rewrite of the IR optimizer. it changes the structure of the binop optimizations so that it is easier to add more optimizations. it also refactors the `clamp` optimizations to be in terms of an `assert` statement, so that the clamp conditions can be optimized using the binop optimizer code. Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
charles-cooper
added a commit
that referenced
this pull request
May 25, 2022
This reverts commit efe1dbe.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
tests pass
Commit Message
Description for the changelog
Cute Animal Picture