optimize ceil32 #2771
Merged
optimize ceil32 #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
down from 9 to 6 instructions (all G_low) also optimize out a couple instances of ceil32
Codecov Report
@@ Coverage Diff @@
## master #2771 +/- ##
==========================================
- Coverage 87.44% 87.41% -0.03%
==========================================
Files 93 93
Lines 9945 9949 +4
Branches 2471 2472 +1
==========================================
+ Hits 8696 8697 +1
- Misses 782 785 +3
Partials 467 467
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Apr 13, 2022
skellet0r
reviewed
Apr 13, 2022
| @@ -876,7 +877,8 @@ def zero_pad(bytez_placeholder): | |||
| # the actual value of X as a byte sequence, | |||
| # followed by the *minimum* number of zero-bytes | |||
| # such that len(enc(X)) is a multiple of 32. | |||
| num_zero_bytes = ["sub", ["ceil32", "len"], "len"] | |||
| # optimized form of ceil32(len) - len: | |||
| num_zero_bytes = ["and", 31, ["sub", 0, "len"]] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
down from 9 to 6 instructions (all G_low)
also optimize out a couple instances of ceil32
What I did
steal a couple easy optimizations out of #2647
How I did it
note that
ceil32(x) == floor32(x + 31)How to verify it
tests still pass
Commit message
Description for the changelog
Cute Animal Picture