Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define publicKeyJwk #35

Merged
merged 3 commits into from
Aug 13, 2020
Merged

Define publicKeyJwk #35

merged 3 commits into from
Aug 13, 2020

Conversation

OR13
Copy link
Collaborator

@OR13 OR13 commented May 7, 2020

create security-v3-unstable.jsonld

add definition for publicKeyJwk

<pre class="example prettyprint language-jsonld">
{
"id": "did:example:123#_Qq0UL2Fq651Q0Fjd6TvnYE-faHiOpRlPVQcY_-tA4A",
"type": "JsonWebKey2020",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked by discussion about JsonWebKey2020/JwkVerificationKey2020... we need to resolve this to pull in this example.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update the name, if the name changes... all of the examples in this repo need a refresh.

msporny
msporny previously requested changes Jun 8, 2020
Copy link
Collaborator

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to resolve the JsonWebKey2020 discussion to pull this in.

@OR13
Copy link
Collaborator Author

OR13 commented Jun 9, 2020

@msporny @kdenhartog I believe we may have a special topic call which would allow for us to address this in the DID WG... its the same topic call that will address:

@kdenhartog
Copy link
Contributor

kdenhartog commented Jun 10, 2020

@msporny @kdenhartog I believe we may have a special topic call which would allow for us to address this in the DID WG... its the same topic call that will address:

* [w3c/did-core#185](https://github.com/w3c/did-core/issues/185)

@OR13 I haven't seen a topic call for that come up yet, but may have missed it. Do you know what day it is or is it still TBD and I should keep my eye out for it? Found it

@OR13
Copy link
Collaborator Author

OR13 commented Jun 23, 2020

Just putting this out there: https://docs.microsoft.com/en-us/microsoft-edge/dev-guide/windows-integration/web-authentication

attestationObject = cbor.decodeFirstSync(Buffer.from(attestation.attestationObject, 'base64'));
    authenticatorData = parseAuthenticatorData(attestationObject.authData);
    var credential = await storage.Credentials.create({
        id: authenticatorData.attestedCredentialData.credentialId.toString('base64'),
        publicKeyJwk: authenticatorData.attestedCredentialData.publicKeyJwk,
        signCount: authenticatorData.signCount
    });

@OR13
Copy link
Collaborator Author

OR13 commented Jul 13, 2020

@msporny what can I do to unblock this?

@peacekeeper
Copy link
Member

Related to the transform-keys DID parameter: https://w3c.github.io/did-spec-registries/#transform-keys-0

@OR13
Copy link
Collaborator Author

OR13 commented Aug 10, 2020

@msporny @dlongley I believe we settled this. note that this is still the "unstable context"... please review again.

@OR13 OR13 dismissed msporny’s stale review August 13, 2020 14:03

Please review again, I think we had no issue with this property, only the values for vm types.

@OR13
Copy link
Collaborator Author

OR13 commented Aug 13, 2020

@msporny as you are currently the only code owner, i am awaiting your review.

Copy link
Collaborator

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with all of the caveats that we're currently discussing this and it may change, etc.)

@msporny msporny merged commit bb6acef into master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants