add definition for publicKeyHex based on RFC4648 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Den Hartog <kyle.denhartog@mattr.global>
OR13
approved these changes
Jun 16, 2020
|
We need this to be defined in a JSON-LD Context... since v3-unstable is currently blocked, how can we add things like this... @msporny ? |
OR13
requested changes
Jun 16, 2020
Why is v3-unstable blocked? |
|
Yup, that's the part I wasn't sure about if it should be added to v2 or v3. Will add to this PR before merging. |
msporny
approved these changes
Jun 16, 2020
Yeah I can do it that way and then we'll just need to resolve the merge conflicts on #35 after. At least then we get v3 started as well. Added this in the latest commit @OR13 |
Signed-off-by: Kyle Den Hartog <kyle.denhartog@mattr.global>
kdenhartog
force-pushed
the
kdh/publicKeyHex
branch
from
c0a07b5
to
f176da5
Compare
OR13
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kyle Den Hartog kyle.denhartog@mattr.global