Menubar2 fixes #525
Merged
Menubar2 fixes #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed that 34894e8 was what added the "toggle but don't close" behavior, which describes that space should do this, but enter should still close. That should now be working. |
|
@sh0ji, Evan, looking great! Many thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #521 & #524.
For #521, I placed the attributes directly on the HTML and removed the JavaScript that was adding various attributes (part of
MenubarItemAction.init()).#524 was relatively straight-forward, but the first point did seem to be deliberately coded into the example.
Note that I also changed the
aria-haspopupelements to anchors from spans to match the menubar-1 pattern. My .editorconfig also appears to have removed some unnecessary whitespace from the HTML.