Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is "entry setings object" correct? #78

Closed
domenic opened this issue Jul 29, 2022 · 1 comment · Fixed by #81
Closed

Is "entry setings object" correct? #78

domenic opened this issue Jul 29, 2022 · 1 comment · Fixed by #81
Assignees
@clelland

Comments

@domenic
Copy link

domenic commented Jul 29, 2022

See whatwg/html#1431. We've mostly managed to remove this from the web platform, and hopefully it isn't what sendBeacon() actually uses in implementations. Has anyone written web platform tests to check?
@clelland
Copy link
Contributor

clelland commented Aug 2, 2022

It doesn't look like there are WPT, but some quick testing seems to show that Chrome, Firefox and Safari all use the environment settings object from sendBeacon's global when resolving relative URLs. (and origin checking, as mentioned in the linked HTML issue, probably has to be the same.)

@clelland clelland mentioned this issue Aug 3, 2022
Merged
clelland added a commit that referenced this issue Aug 3, 2022
@clelland
Merge pull request #81 from clelland/remove-deps
3154c45 
This removes the hand-maintained "Dependencies" section from the spec, and replaces all of the linked terms with ReSpec cross-references.

Additionally, a few stale dependencies have been updated:
 * Page Visibility terms (visibilitychange, visibilityState, unload, and hidden) have been updated to point to their location in HTML.
 * References to the obsolete "entry settings object" have been replaced with "this's relevant settings object", which is the settings object actually used by implementations.

Fixes #68, fixes #77, fixes #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clelland clelland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deps section, properly cross-reference links clelland/beacon
2 participants
@clelland @domenic