Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deps section, properly cross-reference links #81

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Remove deps section, properly cross-reference links #81

merged 1 commit into from
Aug 3, 2022

Conversation

clelland
Copy link
Contributor

@clelland clelland commented Aug 3, 2022 •
edited by pr-preview bot
Loading

This removes the hand-maintained "Dependencies" section from the spec, and replaces all of the linked terms with ReSpec cross-references.

Additionally, a few stale dependencies have been updated:

  • Page Visibility terms (visibilitychange, visibilityState, unload, and hidden) have been updated to point to their location in HTML.
  • References to the obsolete "entry settings object" have been replaced with "this's relevant settings object", which is the settings object actually used by implementations.

Fixes #68, fixes #77, fixes #78

Preview | Diff

@clelland clelland requested a review from yoavweiss August 3, 2022 11:18
yoavweiss
yoavweiss approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clelland clelland merged commit 3154c45 into w3c:gh-pages Aug 3, 2022
@clelland clelland deleted the remove-deps branch August 3, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoavweiss yoavweiss yoavweiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@clelland @yoavweiss