Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non-inlined embedded audio resources to the Data Model? #116

Open
nigelmegitt opened this issue Mar 15, 2023 · 0 comments
Open

Add non-inlined embedded audio resources to the Data Model? #116

nigelmegitt opened this issue Mar 15, 2023 · 0 comments
Labels
PR-must-have Issue that must be resolved before going to Proposed Recommendation (PR) question Further information is requested

Comments

@nigelmegitt
Copy link
Contributor

See also #115 - if we are going to support non-inline embedded audio resources, should we make an object for them and add it into the Data Model?
@nigelmegitt nigelmegitt added the question Further information is requested label Mar 15, 2023
nigelmegitt added a commit that referenced this issue Mar 17, 2023
@nigelmegitt
Add issue #116 link below data model diagram
3369528
nigelmegitt added a commit that referenced this issue Mar 28, 2023
@nigelmegitt
Add issue #116 link below data model diagram
461c571
nigelmegitt added a commit that referenced this issue Mar 28, 2023
@nigelmegitt
Add audio and audio mixing (#118)
b5376b4 
Closes #118 and #71.

* Add Audio and MixingInstruction to the class diagram
* Show shared properties in italics
* Describe syntax of data model diagram
* Define audio recording properties
* Define Mixing Instruction representation in TTML
* Add placeholder for Audio Mixing section
* Define TTML representation of Synthesized Audio
* Note that Audio is abstract
* Add Audio Recording representation
* Also change "defines" to "represents" in TTML representation sections.
* Add `xml:lang` constraints
* Add informative section explaining audio mixing
* Reference audio recording question issues
* Reference issue #117.
* Add embedded audio example, clarify multiple Source, re-add content profile
* Remove unnecessary conformance keywords
* When the conformance is defined in TTML2 already, don't duplicate.
* Add `#source-data` extension and prohibit it
* Add and prohibit `#xmlLang-audio-nonMatching` extension
* Fix up feature support for inline-only animation for mixing instructions
* Add issue #116 link below data model diagram
* Additional examples of audio

Also refer back to examples in the introduction where appropriate.
Fix some linting issues.

* Show Source as an array not one property value
* Audio sources are not nodes
* Add note about extended descriptions
* Add space before : in enum abnf of `daptm:eventType`
* Move Audio Mixing to appendix
* Address verbal review feedback
@nigelmegitt nigelmegitt added the CR must-have Must be resolved before going to CR label May 18, 2023
@nigelmegitt nigelmegitt added PR-must-have Issue that must be resolved before going to Proposed Recommendation (PR) and removed CR must-have Must be resolved before going to CR labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR-must-have Issue that must be resolved before going to Proposed Recommendation (PR) question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nigelmegitt