Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization updates for 4.0.0 #590

Closed
6 of 7 tasks
tofi86 opened this issue Sep 9, 2015 · 19 comments · Fixed by #599
Closed
6 of 7 tasks

Localization updates for 4.0.0 #590

tofi86 opened this issue Sep 9, 2015 · 19 comments · Fixed by #599
Assignees
Milestone

Comments

@tofi86
Copy link
Collaborator

tofi86 commented Sep 9, 2015

Commit 3850128 only documentates the -profile switch for the english/default message properties file, but not for the localizations.

Localizations need to be updated by maintainers:

@tofi86 tofi86 added the type: feature The issue describes a new feature request label Sep 9, 2015
@tofi86 tofi86 added this to the Next milestone Sep 9, 2015
@tofi86
Copy link
Collaborator Author

tofi86 commented Sep 9, 2015

There are also another couple of new and changed text strings. Have a look at the Transifex system for epubcheck translation (#479, https://www.transifex.com/idpf/epubcheck/) to identify the new/changed text strings and create a PullRequest with your changes.

With a Transifex account you're able to either translate the strings in their webapp or identify the changed/new strings and add them to your PullRequest.

@tofi86
Copy link
Collaborator Author

tofi86 commented Sep 9, 2015

when translating messages, especially in com/adobe/epubcheck/messages/MessageBundle.properties, make sure you have the History tab opened on the right in Transifex so you can see previous translations for the current message.

bildschirmfoto 2015-09-09 um 23 19 34

This is useful in case @rdeltour only changed a word in the message but not the whole message itself...

@tofi86 tofi86 reopened this Sep 13, 2015
@tofi86 tofi86 changed the title Documentation of the -profile switch in help text is missing in localizations Localization updates for 4.0.0 Sep 13, 2015
@tofi86 tofi86 removed the type: feature The issue describes a new feature request label Sep 13, 2015
@tofi86
Copy link
Collaborator Author

tofi86 commented Sep 23, 2015

Japanese updates from PR #598 were suqashed and merged to master in 4c32d1b

@rdeltour
Copy link
Member

Hi all. I'll prepare a bugfix release soon (say at the end of next week). I'd like to include any localization update contributed so far. Please let me know if there's anything ongoing before I release. And thanks all for the contribs!

@rdeltour rdeltour modified the milestones: 4.0.1, Next Sep 29, 2015
@pettarin
Copy link

People from LIA/AIE stated that they will take care of the Italian translation (here and at Readium), so I am calling myself out of this task.

@rdeltour
Copy link
Member

@pettarin ok, thanks for the info. Any contact info? Are they following this thread or the epubcheck list? I basically want to make sure they don't miss the 4.0.1 opportunity...

@pettarin
Copy link

It is not clear to me who is in charge of what over there. Asking the Italian member of the IDPF board might help. (If I remember correctly, it was their spoke person who tweeted me that they would have taken care.)

@rdeltour
Copy link
Member

@pettarin ok, thanks!

@tofi86
Copy link
Collaborator Author

tofi86 commented Sep 29, 2015

Just wrote messages to the other Transifex translatiors and asked for their contribution until Oct. 7

So last but not least asking @vincent-gros, @tledoux, @rdeltour whether the three of you see any chance to finish the french translation on Transifex? Thanks :)

@pettarin
Copy link

@rdeltour Sure, you are welcome. BTW, here in epubcheck (generic)you are using the "ping the prev translators/public call for translations (with deadline)" that I suggested for Readium ( readium/readium-js-viewer#40 (comment) ) but AFAICT there it has not been adopted yet. Since I understand (DAISY)you are in both projects, you might want to push it forward. Just saying. Apologies for the off-topic. Bye.

@vincent-gros
Copy link
Contributor

@tledoux, @rdeltour I can finish the french translation this weekend if iit is needed.

@rdeltour
Copy link
Member

@tledoux, @rdeltour I can finish the french translation this weekend if iit is needed.

Great, thanks Vincent! Let me know if you need help...

@tofi86
Copy link
Collaborator Author

tofi86 commented Sep 30, 2015

@vincent-gros Thanks! I think it's the best to finish the translation on Transifex. Otherwise you'll have to watch the file and character encoding closely, as some files are UTF-8 and some not and you would have to manually escape non-ASCII chars...

Let me know if I can help you with anything...

@rdeltour
Copy link
Member

@tofi86 I finalized the french translation (it took a bit longer than expected, with all the new strings from Jing). let me know when you can integrate those!

@tofi86
Copy link
Collaborator Author

tofi86 commented Oct 12, 2015

@rdeltour great! I can integrate the changes this evening. Stay tuned.

@tofi86
Copy link
Collaborator Author

tofi86 commented Oct 12, 2015

I'm also adding the new Dutch translation by Transifex contributor Merijn de Haen also it's still missing the Jing messages.

Nevertheless, thanks Merijn! 🎉

@tofi86 tofi86 self-assigned this Oct 12, 2015
@tofi86
Copy link
Collaborator Author

tofi86 commented Oct 21, 2015

I'm closing this in favor of a quick 4.0.1 release and we're looking forward to integrate the italian translation in a next release.

@tofi86 tofi86 closed this as completed Oct 21, 2015
@tofi86 tofi86 reopened this Oct 22, 2015
@tofi86
Copy link
Collaborator Author

tofi86 commented Oct 22, 2015

Waiting for translations for the only changed text string in 4.0.1:
39c93b2#diff-d690896c18b58160491906e560600966L14

Updated:
en, fr, de, es, nl

Pending:
ja

@tofi86
Copy link
Collaborator Author

tofi86 commented Oct 23, 2015

Pulled translations from Transifex and pushed the processed properties files with 406a200 to master

@tofi86 tofi86 closed this as completed Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants