-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Exposing available payment methods" is confusing given the existence of canMakePayment() #629
Labels
Comments
I can have a go at fixing it. |
I support this request :) |
@lknik, be careful, or we will rope you in to help and review stuff. |
From a republication of CR perspective,this sounds editorial to me. |
Sent PR for this #673 |
marcoscaceres
added a commit
that referenced
this issue
Jan 24, 2018
marcoscaceres
added a commit
that referenced
this issue
Jan 24, 2018
Fixed by #673 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A Chrome developer ended up confused by this section because it says
However this is not true for "the payment request API" in general, only for paymentRequest.show(). In particular canMakePayment() can be called without UI.
This section should be rewritten to be specific what methods it's talking about, and talk about canMakePayment()'s step 3 mitigations additionally.
As a separate problem, the "may" requirements in this section are very bad, and should be moved to the show() method.
I can try to work on this "soon", but it's hard to guarantee availability for this week or next, so since it seems things are heading toward some sort of spec freeze, maybe someone else can help out here.
The text was updated successfully, but these errors were encountered: