show() must be triggered by user activation #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this has significant impact on the test suite. So, once we have agreement we will need to deal with that before merging. |
marcoscaceres
force-pushed
the
triggered_by_user_activation
branch
2 times, most recently
from
143bd40
to
fbdd4ec
Compare
domenic
approved these changes
Dec 1, 2017
|
We can implement this only after show promise. (Otherwise some merchants will break.) Landing the spec change is OK. |
|
@rsolomakhin, ok, good to know... Let's try land them together. |
This was referenced Jan 23, 2018
Closed
Merged
|
This is implemented in WebKit already. Added link to Gecko bug. @rsolomakhin, do you have a bug number for Chrome? |
marcoscaceres
force-pushed
the
triggered_by_user_activation
branch
from
c3c14b8
to
1d93a6e
Compare
|
Rebased... bit rot. |
marcoscaceres
force-pushed
the
triggered_by_user_activation
branch
from
1d93a6e
to
207d1ca
Compare
This was referenced Mar 13, 2018
links to payment-request-show-method-manual.https.html
|
Quick update... I've changed the necessary WPTests to be manual. Just waiting on reviews and we should be good to merge. Marking a blocked on those. |
rsolomakhin
approved these changes
Mar 13, 2018
|
Ok, tests are updated, so feel ok about merging this. |
|
@ianbjacobs, could you please send a request to republish the document? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #651
The following tasks have been completed:
Implementation commitment:
Preview | Diff