Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: diversify currencies of examples #943

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Editorial: diversify currencies of examples #943

merged 2 commits into from
Mar 17, 2021

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Mar 16, 2021 •
edited by pr-preview bot
Loading

@marcoscaceres marcoscaceres mentioned this pull request Mar 16, 2021
Closed
ianbjacobs
ianbjacobs reviewed Mar 16, 2021
View reviewed changes
index.html Outdated Show resolved Hide resolved
ianbjacobs
ianbjacobs reviewed Mar 16, 2021
View reviewed changes
Copy link
Collaborator

@ianbjacobs ianbjacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marcoscaceres,

Seems good to me except YEN=>JPY. Thanks!

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Mar 17, 2021 •
edited
Loading

Web spotted, @ianbjacobs. When you can, could you explicitly approve the PR in the review files view? (otherwise, GH won't let me merge)

@marcoscaceres marcoscaceres merged commit b791452 into gh-pages Mar 17, 2021
@marcoscaceres marcoscaceres deleted the examples branch March 17, 2021 04:20
@aphillips aphillips mentioned this pull request Mar 31, 2021
Closed
@ianbjacobs
Copy link
Collaborator

@aphillips, does this pull request satisfy the I18N folks?

aphillips
aphillips reviewed Apr 19, 2021
View reviewed changes
index.html Show resolved Hide resolved
aphillips
aphillips reviewed Apr 20, 2021
View reviewed changes
index.html Show resolved Hide resolved
@aphillips
Copy link

@ianbjacobs Nits aside, it does. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphillips aphillips aphillips left review comments

@ianbjacobs ianbjacobs ianbjacobs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-US examples?
3 participants
@marcoscaceres @ianbjacobs @aphillips